Opened 3 years ago

Last modified 22 months ago

#19741 new defect

favicon in searchbar popup uses catchall circuit

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-linkability, ff52-esr, TorBrowserTeam201702
Cc: gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

To reproduce:

  • Set "torbutton.loglevel" to 3.
  • Enter the word "test" in the searchbar. Click on the DuckDuckGo icon in the popup menu below to cause a search for "test" to be performed on DuckDuckGo. After the search is performed, a green "plus" symbol appears on the searchbar magnifying glass icon.
  • Open the browser console, and clear it.
  • Click on the searchbar again. An additional menu item appears, which contains the text Add "DuckDuckGo (HTML)" and a DuckDuckGo favicon.
  • Examine the browser console. Log messages should appear as follows:
    [07-22 22:38:01] Torbutton INFO: tor SOCKS: http://3g2upl4pq6kufc4m.onion/favicon.ico via --NoFirstPartyHost-chrome-browser.xul--:9bb8a61534faf1f952647a3537560fb0
    GET 
    http://3g2upl4pq6kufc4m.onion/favicon.ico [HTTP/1.1 200 OK 0ms]
    getFirstPartyURI failed for chrome://browser/content/browser.xul: 0x80070057
    [07-22 22:38:02] Torbutton INFO: controlPort >> 650 STREAM 264 NEW 0 3g2upl4pq6kufc4m.onion:80 SOURCE_ADDR=127.0.0.1:52895 PURPOSE=USER
    [07-22 22:38:02] Torbutton INFO: controlPort >> 650 STREAM 264 SENTCONNECT 15 3g2upl4pq6kufc4m.onion:80
    getFirstPartyURI failed for chrome://browser/content/browser.xul: 0x80070057
    [07-22 22:38:02] Torbutton INFO: controlPort >> 650 STREAM 264 SUCCEEDED 15 3g2upl4pq6kufc4m.onion:80
    
    should be visible. I believe these messages are caused by

So it appears that the favicon display inside "add-engines" vbox of the search popup is being sent over the catchall circuit.

Child Tickets

Change History (12)

comment:1 Changed 3 years ago by arthuredelstein

Component: - Select a componentApplications/Tor Browser
Keywords: tbb-linkability TorBrowserTeam201607 added
Owner: set to tbb-team

comment:2 Changed 3 years ago by gk

Cc: gk added

comment:3 Changed 3 years ago by gk

Keywords: TorBrowserTeam201608 added; TorBrowserTeam201607 removed

Moving items to August 2016.

comment:4 Changed 3 years ago by bugzilla

Congrats! You've rediscovered ticket:18937#comment:22!
Also don't forget about it's OCSP request like in #19416.

comment:5 Changed 3 years ago by gk

Keywords: TorBrowserTeam201609 added; TorBrowserTeam201608 removed

Tickets for September.

comment:6 Changed 2 years ago by gk

Keywords: TorBrowserTeam201610 added; TorBrowserTeam201609 removed

Moving tickets to October.

comment:7 Changed 2 years ago by gk

Keywords: TorBrowserTeam201611 added; TorBrowserTeam201610 removed

Moving tickets over to November.

comment:8 Changed 2 years ago by gk

Keywords: TorBrowserTeam201612 added; TorBrowserTeam201611 removed

Moving tickets to December.

comment:9 Changed 2 years ago by gk

Keywords: ff52-esr added

Getting it on our ESR52 radar for double-checking as it might already be solved by the first-party isolation upstreaming.

comment:10 Changed 2 years ago by gk

Keywords: TorBrowserTeam201701 added; TorBrowserTeam201612 removed

Moving our tickets to January 2017

comment:11 Changed 2 years ago by gk

Keywords: TorBrowserTeam201702 added; TorBrowserTeam201701 removed

Moving our tickets to Feb 2017.

comment:12 Changed 22 months ago by gk

Still an issue with ESR52.

Note: See TracTickets for help on using tickets.