Opened 7 years ago

Closed 6 years ago

#1976 closed enhancement (fixed)

Implement PID control feedback for bw auths

Reported by: mikeperry Owned by: mikeperry
Priority: High Milestone: Deliverable-Nov2011
Component: Core Tor/Torflow Version:
Severity: Keywords: MikePerryIteration20111106
Cc: karsten Actual Points: 26
Parent ID: #2769 Points: 10
Reviewer: Sponsor:

Description

We should be able to get better feedback measurements from bw authorites if we make them smarter about tracking when they last measured a relay. They should only apply their ALPHA feedback loop if they have a new measurement in this round of voting.

This should fix the feedback problems we saw when we turned this feature on before.

Child Tickets

Change History (10)

comment:1 Changed 7 years ago by mikeperry

We need to double check the timestamp field to ensure that it is really the measurement time, but otherwise this should be as simple as comparing the measurement timestamp to the timestamp from the current consensus.

We may want to SETCONF both FetchDirInfoExtraEarly and FetchDirInfoEarly to ensure we get a consensus every hour, so that we know if the measurement was after it was published, and we know the most recent value.

comment:2 Changed 7 years ago by mikeperry

Parent ID: #2769

Adding this to the list of experiments for the tech report, though we may not get to it till right before the camera deadline.

comment:3 Changed 7 years ago by mikeperry

#2550 is potentially going to change how this works, because of the delay in choosing an advertised value..

comment:4 Changed 6 years ago by mikeperry

Type: defectenhancement

comment:5 Changed 6 years ago by mikeperry

Milestone: Deliverable-Nov2011
Priority: normalmajor
Status: newneeds_information

comment:6 Changed 6 years ago by mikeperry

Status: needs_informationaccepted

What is with the radiobutton juggling...

comment:7 Changed 6 years ago by mikeperry

Keywords: MikePerryIterationReport2011106 added
Points: 10

comment:8 Changed 6 years ago by mikeperry

Keywords: MikePerryIteration20111106 added; MikePerryIterationReport2011106 removed

comment:9 Changed 6 years ago by mikeperry

Cc: karsten added

This is now running on the chicago vm (which votes to urrass). See https://gitweb.torproject.org/mikeperry/torflow.git/blob/pid_control:/NetworkScanners/BwAuthority/README.spec.txt section 3 for details.

I included a fix for #1984, as well.

We'll see how it goes.

comment:10 Changed 6 years ago by mikeperry

Actual Points: 26
Resolution: fixed
Status: acceptedclosed
Summary: Bw Authorities should apply ALPHA multiplier only if measurements changeImplement PID control feedback for bw auths

Spent quite a bit of time on this. It appears to be running fine on one bw auth. I created #4425 to monitor it and deploy on the others.

Note: See TracTickets for help on using tickets.