Opened 3 years ago

Closed 2 years ago

#19783 closed defect (fixed)

Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`

Reported by: dcf Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Minor Keywords: tbb-gitian, ff52-esr, TorBrowserTeam201704R
Cc: Actual Points:
Parent ID: #21328 Points:
Reviewer: Sponsor:

Description

build-helpers/i686-apple-darwin11-g++ and build-helpers/i686-apple-darwin11-gcc have a typo:

-DMAXOSX_DEPLOYEMENT_TARGET=10.6

There are actually two bugs: MAXOSX not MACOSX and DEPLOYEMENT not DEPLOYMENT.

Since this define has probably never had an effect, I suppose it can be removed.

Child Tickets

Change History (9)

comment:1 Changed 3 years ago by gk

Keywords: tbb-gitian added

comment:2 Changed 3 years ago by gk

Keywords: TorBrowserTeam201703 tbb-7.0-must added

That's supposed to be 10.7 since https://bugzilla.mozilla.org/show_bug.cgi?id=1269790. We should fix the typo and adapt that while transitioning to ESR 52

comment:3 Changed 3 years ago by gk

Keywords: ff52-esr added; tbb-7.0-must removed

I am fine with removing that as well. It might actually be the better way to handle this bug as 10.7 is the default anyway.

comment:4 Changed 3 years ago by gk

And even better would be to get rid of those helper script in the first place by moving the remaining parts to our clang-based cross-compile setup. We are close.

comment:5 Changed 3 years ago by gk

Parent ID: #21328

comment:6 Changed 2 years ago by gk

Keywords: TorBrowserTeam201703R added; TorBrowserTeam201703 removed
Status: newneeds_review

bug_19783 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_19783&id=85693f597f65269daf49d9d93f129f9cabe673ce) has a commit that removes those helper scripts. It is on top of the fixes for #10369 and #21753.

comment:7 in reply to:  6 Changed 2 years ago by boklm

Replying to gk:

bug_19783 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_19783&id=85693f597f65269daf49d9d93f129f9cabe673ce) has a commit that removes those helper scripts. It is on top of the fixes for #10369 and #21753.

This looks good to me.

comment:8 Changed 2 years ago by gk

Keywords: TorBrowserTeam201704R added; TorBrowserTeam201703R removed

Moving review tickets to April.

comment:9 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

This is commit d744cac29e8df0efaf1a6bb3a626be90e930c118 on master.

Note: See TracTickets for help on using tickets.