Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`

build-helpers/i686-apple-darwin11-g++ and build-helpers/i686-apple-darwin11-gcc have a typo:

-DMAXOSX_DEPLOYEMENT_TARGET=10.6

There are actually two bugs: MAXOSX not MACOSX and DEPLOYEMENT not DEPLOYMENT.

Since this define has probably never had an effect, I suppose it can be removed.

added TorBrowserTeam201704R component::applications/tor browser ff52-esr owner::tbb-team parent::21328 priority::medium resolution::fixed severity::minor status::closed tbb-gitian type::defect labels

Trac:
Keywords: N/A deleted, tbb-gitian added

That's supposed to be 10.7 since https://bugzilla.mozilla.org/show_bug.cgi?id=1269790. We should fix the typo and adapt that while transitioning to ESR 52

Trac:
Keywords: N/A deleted, TorBrowserTeam201703, tbb-7.0-must added

I am fine with removing that as well. It might actually be the better way to handle this bug as 10.7 is the default anyway.

Trac:
Keywords: tbb-7.0-must deleted, ff52-esr added

And even better would be to get rid of those helper script in the first place by moving the remaining parts to our clang-based cross-compile setup. We are close.

Trac:
Parent: N/A to #21328 (moved)

bug_19783 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_19783&id=85693f597f65269daf49d9d93f129f9cabe673ce) has a commit that removes those helper scripts. It is on top of the fixes for #10369 (moved) and #21753 (moved).

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201703 deleted, TorBrowserTeam201703R added

Replying to gk:

bug_19783 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_19783&id=85693f597f65269daf49d9d93f129f9cabe673ce) has a commit that removes those helper scripts. It is on top of the fixes for #10369 (moved) and #21753 (moved).

This looks good to me.

Moving review tickets to April.

Trac:
Keywords: TorBrowserTeam201703R deleted, TorBrowserTeam201704R added

This is commit d744cac29e8df0efaf1a6bb3a626be90e930c118 on master.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #21754 (moved)

moved to tpo/applications/tor-browser#19783 (closed)