Opened 3 years ago

Closed 3 years ago

#19818 closed task (fixed)

The update_responses script should use a config.yml option for the releases directory path

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201608R, tbb-gitian
Cc: sukhbir Actual Points:
Parent ID: #19817 Points:
Reviewer: Sponsor:

Description

The directory containing the releases is currently set in the update_responses script to ../../gitian. This directory will be different for Tor Messenger.

In order to be able to share the update_responses script between Tor Browser and Tor Messenger without modification, we should add a releases_dir option in the config.yml file.

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by sukhbir

Cc: sukhbir added

comment:2 Changed 3 years ago by boklm

Keywords: TorBrowserTeam201608R added
Status: newneeds_review

comment:3 Changed 3 years ago by gk

Keywords: tbb-gitian added

Do we need that on maint-6.0 as well?

comment:4 Changed 3 years ago by boklm

Yes, having the same version of the script in maint-6.0 and master could make merging future patches easier.

comment:5 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Fixed on master, maint-6.0 and hardened-builds (commit 260c051a69a7323084793c23c6ed53cd1344dd72, 1bb5bba64b60009c3deb8cc5119dd41d7615f3d4 and fcf89874d5b9919633d312e89d8aea529f5664d2).

Note: See TracTickets for help on using tickets.