Add deprecation facility, and deprecate some old options

changed milestone to %Tor: 0.2.9.x-final

added TorCoreTeam201608 actualpoints::.5 component::core tor/tor milestone::Tor: 0.2.9.x-final owner::nickm points::1 priority::medium resolution::implemented review-group-7 reviewer::dgoulet severity::normal status::closed type::defect labels

Trac:
Owner: N/A to nickm
Component: - Select a component to Core Tor/Tor
Status: new to accepted

My deprecation_v2 branch marks a bunch of options and sub-options as in need of removal. Please review?

Trac:
Status: accepted to needs_review

Oh! I do have a ticket that does part of this. assigning as parent.

Trac:
Parent: N/A to #18857 (moved)

Oh! I do have a ticket that does part of this. assigning as parent.

Trac:
Points: .5 to 1

Trac:
Keywords: N/A deleted, TorCoreTeam201608 added

Trac:
Keywords: N/A deleted, review-group-7 added

Trac:
Parent: #18857 (moved) to N/A

Only one question. Why aren't we calling config_assign() with the deprecation flag CAL_WARN_DEPRECATIONS if testing network is on? See config.c +4966. I guess we don't want to warn for testing but I think we should actually so anyone out there (and us) know what could be useless to test or about to die?

Apart from that, this lgtm! Marking it merge_ready, leaving it to your discretion to change the above or not.

Trac:
Status: needs_review to merge_ready

actual-review-point: 0.1

Trac:
Reviewer: N/A to dgoulet

Merged.

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

closed

changed time estimate to 8h

added 4h of time spent

mentioned in issue #22572 (moved)

moved to tpo/core/tor#19820 (closed)