Opened 3 years ago

Closed 3 years ago

#19820 closed defect (implemented)

Add deprecation facility, and deprecate some old options

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: TorCoreTeam201608, review-group-7
Cc: Actual Points: .5
Parent ID: Points: 1
Reviewer: dgoulet Sponsor:

Description


Child Tickets

Change History (10)

comment:1 Changed 3 years ago by nickm

Component: - Select a componentCore Tor/Tor
Owner: set to nickm
Status: newaccepted

comment:2 Changed 3 years ago by nickm

Status: acceptedneeds_review

My deprecation_v2 branch marks a bunch of options and sub-options as in need of removal. Please review?

comment:3 Changed 3 years ago by nickm

Parent ID: #18857

Oh! I do have a ticket that does part of this. assigning as parent.

comment:4 Changed 3 years ago by nickm

Points: .51

Oh! I do have a ticket that does part of this. assigning as parent.

comment:5 Changed 3 years ago by nickm

Keywords: TorCoreTeam201608 added

comment:6 Changed 3 years ago by nickm

Keywords: review-group-7 added

comment:7 Changed 3 years ago by nickm

Parent ID: #18857

comment:8 Changed 3 years ago by dgoulet

Status: needs_reviewmerge_ready

Only one question. Why aren't we calling config_assign() with the deprecation flag CAL_WARN_DEPRECATIONS if testing network is on? See config.c +4966. I guess we don't want to warn for testing but I think we should actually so anyone out there (and us) know what could be useless to test or about to die?

Apart from that, this lgtm! Marking it merge_ready, leaving it to your discretion to change the above or not.

comment:9 Changed 3 years ago by dgoulet

Reviewer: dgoulet

actual-review-point: 0.1

comment:10 Changed 3 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged.

Note: See TracTickets for help on using tickets.