Opened 3 years ago

Closed 3 years ago

#19831 closed enhancement (fixed)

Change default for compressing descriptors to true

Reported by: karsten Owned by: iwakeh
Priority: Low Milestone: CollecTor 1.1.0
Component: Metrics/CollecTor Version:
Severity: Normal Keywords:
Cc: iwakeh Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Long ago, there was a bug in tor that broke compressed downloads provided via the DirPort (#11648). The fix went into 0.2.5, so we can safely assume that all directory authorities have upgraded and don't have this bug anymore. Two separate checks have confirmed that fetching compressed descriptors works without issues. We should change the default to save everybody's bandwidth.

Trivial patch:

diff --git a/src/main/resources/collector.properties b/src/main/resources/collector.properties
index e7d41ae..a108673 100644
--- a/src/main/resources/collector.properties
+++ b/src/main/resources/collector.properties
@@ -101,7 +101,7 @@ DownloadAllServerDescriptors = false
 DownloadAllExtraInfoDescriptors = false
 #
 ## Compress relay descriptors downloads by adding .z to the URLs
-CompressRelayDescriptorDownloads = false
+CompressRelayDescriptorDownloads = true
 #
 ## Relative path to directory to write directory archives to
 DirectoryArchivesOutputDirectory = out/relay-descriptors/

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by karsten

Note: We could easily move this ticket to 1.1.0 and resolve it together with #8799.

comment:2 Changed 3 years ago by iwakeh

Milestone: CollecTor 1.0.0CollecTor 1.1.0

Changed milestone as suggested.

comment:3 Changed 3 years ago by iwakeh

Owner: set to iwakeh
Status: newassigned

assigning these issues.

comment:4 Changed 3 years ago by iwakeh

Milestone: CollecTor 1.1.0CollecTor 1.2.0

comment:5 Changed 3 years ago by iwakeh

Milestone: CollecTor 1.2.0CollecTor 1.1.0

comment:6 Changed 3 years ago by iwakeh

Status: assignedneeds_review

Change is here.

comment:7 Changed 3 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Looks good, merged. Closing. Thanks!

Note: See TracTickets for help on using tickets.