#19858 closed task (implemented)

Move guard state out of globals per new guard plan

Reported by: andrea Owned by: andrea
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: nickm-deferred-20161005
Cc: asn Actual Points: 6
Parent ID: #19877 Points: 3
Reviewer: Sponsor: SponsorU-must

Description

New guard plan summarized here at https://lists.torproject.org/pipermail/tor-dev/2016-July/011234.html

1) Create main guard selection state data structure (instead of using global variables)

  • Ideally there should be no global variables, so that in the future we can have multiple parallel guardsets (e.g. prop247)
  • Thoughtworks: guard_selection_t

Child Tickets

Change History (11)

comment:1 Changed 13 months ago by andrea

Parent ID: #19877

comment:2 Changed 12 months ago by isabela

Sponsor: SponsorUSponsorU-must

comment:3 Changed 11 months ago by andrea

Actual Points: 6
Status: newneeds_review

This is done in my ticket19858 branch now. For now existing calls into entryguards.c just use the default guard context; later on we'll need to figure out which call sites care about using a particular one once we have particular ones.

comment:4 Changed 11 months ago by nickm

Thanks! Would you like to make a gitlab pull request for this so it's easier for me to review? Or should I?

comment:6 Changed 11 months ago by nickm

Status: needs_reviewneeds_revision

I noted a couple of small revisions on the gitlab link. Should be pretty quick. Thanks!

comment:7 Changed 11 months ago by nickm

Keywords: nickm-deferred-20161005 added
Milestone: Tor: 0.2.9.x-finalTor: 0.3.0.x-final

Deferring big/risky-feature things (even the ones I really love!) to 0.3.0. Please argue if I'm wrong.

comment:8 Changed 10 months ago by andrea

Status: needs_revisionneeds_review

My ticket19858_v2 branch has revisions from gitlab now

comment:9 Changed 10 months ago by asn

Cc: asn added

comment:10 Changed 10 months ago by nickm

Status: needs_reviewmerge_ready

lgtm

comment:11 Changed 10 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.