Opened 15 months ago

Closed 3 months ago

#19871 closed defect (implemented)

Crypto operation counters are unused and obsolete

Reported by: asn Owned by: isis
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version: Tor: 0.1.2.4-alpha
Severity: Normal Keywords: 029-proposed technnical-debt dead-code easy
Cc: isis Actual Points:
Parent ID: Points: 0.3
Reviewer: Sponsor: Sponsor3-can

Description

Nick told me that the crypto operation counters in rephist.c are considered unused and obsolete.

I'm talking about the counters at note_crypto_pk_op() etc.

Removing code is always good, so if these things are unused we might as well remove them.

Child Tickets

Change History (12)

comment:1 Changed 13 months ago by nickm

Keywords: 029-nickm-says-no added

comment:2 Changed 11 months ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:3 Changed 10 months ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:4 Changed 5 months ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:5 Changed 5 months ago by nickm

Keywords: 029-nickm-says-no removed

comment:6 Changed 4 months ago by nickm

Keywords: technnical-debt dead-code easy added

comment:7 Changed 4 months ago by isis

Cc: isis added

comment:8 Changed 3 months ago by isis

Sponsor: Sponsor3-can

comment:9 Changed 3 months ago by isis

Milestone: Tor: unspecifiedTor: 0.3.2.x-final
Owner: set to isis
Status: newaccepted

The only place these statistics are used is at the end of dumpstats(int severity) where dump_pk_ops() is called after getting a SIGUSR1 signal (but only if severity < LOG_INFO). You're both right that these statistics seem a bit useless, because this info is kind of weird info to keep around, i.e. I'm not sure why we'd want to know how many times we did TLS or how many signatures we verified. (More seemingly useful info about public key operations would be higher-level, e.g. routers we're talking to for which some crypto operation has an anomalous failure rate.)

comment:10 Changed 3 months ago by isis

Version: Tor: 0.1.2.4-alpha

comment:11 Changed 3 months ago by isis

Status: acceptedneeds_review

Please see my patch in my bug19871 branch.

comment:12 Changed 3 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged to master; thanks!

Note: See TracTickets for help on using tickets.