Crypto operation counters are unused and obsolete

Nick told me that the crypto operation counters in rephist.c are considered unused and obsolete.

I'm talking about the counters at note_crypto_pk_op() etc.

Removing code is always good, so if these things are unused we might as well remove them.

changed milestone to %Tor: 0.3.2.x-final

added 029-proposed component::core tor/tor dead-code easy milestone::Tor: 0.3.2.x-final owner::isis points::0.3 priority::medium resolution::implemented severity::normal sponsor::3-can status::closed technnical-debt type::defect version::tor 0.1.2.4-alpha labels

Trac:
Keywords: N/A deleted, 029-nickm-says-no added

Milestone renamed

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.3.???

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

Trac:
Keywords: N/A deleted, tor-03-unspecified-201612 added
Milestone: Tor: 0.3.??? to Tor: unspecified

Remove an old triaging keyword.

Trac:
Keywords: tor-03-unspecified-201612 deleted, N/A added

Trac:
Keywords: 029-nickm-says-no deleted, N/A added

Trac:
Keywords: 029-proposed deleted, 029-proposed technnical-debt dead-code easy added

Trac:
Cc: N/A to isis

Trac:
Sponsor: N/A to Sponsor3-can

The only place these statistics are used is at the end of dumpstats(int severity) where dump_pk_ops() is called after getting a SIGUSR1 signal (but only if severity < LOG_INFO). You're both right that these statistics seem a bit useless, because this info is kind of weird info to keep around, i.e. I'm not sure why we'd want to know how many times we did TLS or how many signatures we verified. (More seemingly useful info about public key operations would be higher-level, e.g. routers we're talking to for which some crypto operation has an anomalous failure rate.)

Trac:
Status: new to accepted
Milestone: Tor: unspecified to Tor: 0.3.2.x-final
Owner: N/A to isis

Trac:
Version: N/A to Tor: 0.1.2.4-alpha

Please see my patch in my bug19871 branch.

Trac:
Status: accepted to needs_review

Merged to master; thanks!

Trac:
Status: needs_review to closed
Resolution: N/A to implemented

closed

changed time estimate to 2h 24m

moved to tpo/core/tor#19871 (closed)