Opened 4 years ago

Closed 4 years ago

#19878 closed task (implemented)

Sample SAMPLED_GUARDS from GUARDS per new guard plan

Reported by: andrea Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: isaremoved, nickwants029, tor-guards-revamp, nickm-deferred-20161005, TorCoreTeam201611
Cc: asn Actual Points:
Parent ID: #19877 Points: 3
Reviewer: Sponsor: SponsorU-must


New guard plan summarized at


  • Fill in state for each sampled guard (added_on_date, etc.)
  • Save/load SAMPLED_GUARDS to/from state
  • Unittests for sampling/saving/loading
  • Thoughtworks function: fill_sampled_guards_from_entrynodes()
  • Thoughtworks unittest: test_fill_in_sampled_set()

Child Tickets

Change History (8)

comment:1 Changed 4 years ago by isabela

Keywords: isaremoved added
Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

comment:2 Changed 4 years ago by nickm

Keywords: nickwants029 tor-guards-revamp added

Batch modification: I believe these are all (or nearly all!) required for the successful completion of the SponorU guards task.

comment:3 Changed 4 years ago by asn

Cc: asn added

comment:4 Changed 4 years ago by isabela

Milestone: Tor: 0.2.???Tor: 0.2.9.x-final
Sponsor: SponsorUSponsorU-must

comment:5 Changed 4 years ago by nickm

Keywords: nickm-deferred-20161005 added
Milestone: Tor: 0.2.9.x-finalTor: 0.3.0.x-final

Deferring more things -- even ones I love -- to 0.3.0. Please argue if I'm wrong.

comment:6 Changed 4 years ago by andrea

Owner: set to andrea
Status: newassigned

comment:7 Changed 4 years ago by nickm

Owner: changed from andrea to nickm

These features are now implemented in my (much-rebased, very unstable) prop271 branch. Because #19889 is not done yet, however, they don't actually do anything yet. At least there are tests and documentation?

comment:8 Changed 4 years ago by nickm

Keywords: TorCoreTeam201611 added
Resolution: implemented
Status: assignedclosed
Note: See TracTickets for help on using tickets.