Opened 3 years ago

Closed 3 years ago

#19893 closed defect (fixed)

Include resources in tarball

Reported by: karsten Owned by: karsten
Priority: Low Milestone: metrics-lib 1.4.0
Component: Metrics/Library Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

While putting out the first CollecTor release I noticed that the release tarball of metrics-lib does not include resource files src/main/resources/* and src/test/resources/*. We should include them in the next release tarball.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by karsten

Status: newneeds_review

Please review the trivial patch in my my task-19893 branch.

comment:2 Changed 3 years ago by iwakeh

Status: needs_reviewmerge_ready

Looks fine, although wouldn't it suffice to include the entire source folder?

like:

<tarfileset dir="src"
           prefix="descriptor-${release.version}/src" />

or using a new property

...
<property name="allsources" value="src"/>
...
<tarfileset dir="${allsources}"
           prefix="descriptor-${release.version}/${allsources}" />

(Btw, I only noticed this ticket by accident.)

comment:3 Changed 3 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Good idea to just include the entire source folder. Amended my earlier patch and pushed to master. I'll make sure to explicitly copy you on future tickets. Closing. Thanks!

Note: See TracTickets for help on using tickets.