Opened 3 years ago

Closed 3 years ago

#19898 closed enhancement (fixed)

Use default search in about:tor in our alpha builds

Reported by: f451022 Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201701R
Cc: alison, i139 Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by gk)

maybe can use the default search engine on aobut:tor, like firefox make with about:home?

Child Tickets

Change History (12)

comment:1 Changed 3 years ago by cypherpunks

Component: - Select a componentApplications/Tor Browser
Owner: set to tbb-team

comment:2 Changed 3 years ago by gk

Description: modified (diff)
Summary: Use defalt search in about:torUse default search in about:tor in our alpha builds

This seems to work for me in our stable series. But the alpha needs an update after moving to DuckDuckGo directly.

comment:3 Changed 3 years ago by bugzilla

#20397 is a duplicate.

comment:4 in reply to:  3 Changed 3 years ago by gk

Cc: alison added
Keywords: TorBrowserTeam201610 added
Type: defectenhancement

Replying to bugzilla:

#20397 is a duplicate.

That bug is about the text which gets shown on about:tor. But I guess we can take care of that one here as well when we change the search engine. Putting it on our radar.

comment:5 Changed 3 years ago by gk

Keywords: TorBrowserTeam201611 added; TorBrowserTeam201610 removed

Moving tickets over to November.

comment:6 Changed 3 years ago by gk

Note: make sure this works with JS disabled as well.

comment:7 Changed 3 years ago by gk

Cc: i139 added

Resolved #20696 as duplicate.

comment:8 Changed 3 years ago by gk

Keywords: TorBrowserTeam201611R added; TorBrowserTeam201611 removed
Status: newneeds_review

comment:9 Changed 3 years ago by gk

Keywords: TorBrowserTeam201612R added; TorBrowserTeam201611R removed

Moving our review tickets to December.

comment:10 Changed 3 years ago by gk

Keywords: TorBrowserTeam201701R added; TorBrowserTeam201612R removed

Moving review tickets to January 2017

comment:11 Changed 3 years ago by mcs

r=brade
r=mcs

The proposed fix looks fine. The original reporter may have been asking for something more sophisticated though: when the user changes their default search engine, the about:tor page should use it (which is how things work for about:home).

comment:12 in reply to:  11 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Replying to mcs:

The original reporter may have been asking for something more sophisticated though: when the user changes their default search engine, the about:tor page should use it (which is how things work for about:home).

Maybe? I was actually not aware of that feature (seems I used Firefox a long time ago/not in that way). I've opened #21218 for that.

Commit 5047691041679494ff17a2258e2721e7200a91a2 on Torbutton master has the fix that got reviewed.

Note: See TracTickets for help on using tickets.