Use default search in about:tor in our alpha builds

maybe can use the default search engine on aobut:tor, like firefox make with about:home?

Trac:
Username: f451022

added TorBrowserTeam201701R component::applications/tor browser owner::tbb-team priority::medium reporter::f451022 resolution::fixed severity::normal status::closed type::enhancement labels

Trac:
Component: - Select a component to Applications/Tor Browser
Owner: N/A to tbb-team

This seems to work for me in our stable series. But the alpha needs an update after moving to DuckDuckGo directly.

Trac:
Description: maybe can use the defalt search engine on aobut:tor, like firefox make with about:home?

to

maybe can use the default search engine on aobut:tor, like firefox make with about:home?
Summary: Use defalt search in about:tor to Use default search in about:tor in our alpha builds

#20397 (moved) is a duplicate.

Replying to bugzilla:

#20397 (moved) is a duplicate.

That bug is about the text which gets shown on about:tor. But I guess we can take care of that one here as well when we change the search engine. Putting it on our radar.

Trac:
Cc: N/A to alison
Type: defect to enhancement
Keywords: N/A deleted, TorBrowserTeam201610 added

Moving tickets over to November.

Trac:
Keywords: TorBrowserTeam201610 deleted, TorBrowserTeam201611 added

Note: make sure this works with JS disabled as well.

Resolved #20696 (moved) as duplicate.

Trac:
Cc: alison to alison, i139

bug_19898_v2 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_19898_v2&id=1c07413da0e34f8bb019dc58213aa938e30ad27d) is up for review.

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201611 deleted, TorBrowserTeam201611R added

Moving our review tickets to December.

Trac:
Keywords: TorBrowserTeam201611R deleted, TorBrowserTeam201612R added

Moving review tickets to January 2017

Trac:
Keywords: TorBrowserTeam201612R deleted, TorBrowserTeam201701R added

r=brade r=mcs

The proposed fix looks fine. The original reporter may have been asking for something more sophisticated though: when the user changes their default search engine, the about:tor page should use it (which is how things work for about:home).

Replying to mcs:

The original reporter may have been asking for something more sophisticated though: when the user changes their default search engine, the about:tor page should use it (which is how things work for about:home).

Maybe? I was actually not aware of that feature (seems I used Firefox a long time ago/not in that way). I've opened #21218 (moved) for that.

Commit 5047691041679494ff17a2258e2721e7200a91a2 on Torbutton master has the fix that got reviewed.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #20397 (moved)

mentioned in issue #20696 (moved)

mentioned in issue #20972 (moved)

mentioned in issue #21078 (moved)

mentioned in issue #27507 (moved)

moved to tpo/applications/tor-browser#19898 (closed)