Opened 15 months ago

Closed 14 months ago

Last modified 14 months ago

#19902 closed defect (fixed)

Dual-install of libevent 1 and libevent 2 on openbsd confuses our autoconf logic

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: openbsd, review-group-8, regression
Cc: cb@… Actual Points: .2
Parent ID: Points: .2
Reviewer: Sponsor:

Description


Child Tickets

Change History (9)

comment:1 Changed 15 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 15 months ago by nickm

Status: acceptedneeds_review

I think the problem may be that we demand header files that exist only in libevent 2, but we accept libraries that only support libevent 1... until we finally link.

Possible fix in branch bug19902_try1 in my public repository. I claim we should merge it whether it fixes the issue on openbsd or not.

comment:3 Changed 15 months ago by nickm

Keywords: review-group-7 added

comment:4 Changed 14 months ago by rubiate

Cc: cb@… added

See my comment and patch on #19758, sorry I wasn't aware this had a separate ticket.

The patch in that branch wouldn't work because that whole conditional is being skipped.

comment:5 Changed 14 months ago by dgoulet

Status: needs_reviewneeds_revision

comment:6 Changed 14 months ago by nickm

Keywords: review-group-8 added; review-group-7 removed

comment:7 Changed 14 months ago by nickm

Sorry for the delay here -- the first half-a-dozen times I looked at this, it looked wrong to me. But now I understand: I think this should work okay.

comment:8 Changed 14 months ago by nickm

Keywords: regression added
Resolution: fixed
Status: needs_revisionclosed

Merged as fe9cfeba6ec96c11d009f4d57bf03f0019e34c9d. Thank you!

comment:9 Changed 14 months ago by nickm

Actual Points: .2
Note: See TracTickets for help on using tickets.