Opened 3 years ago

Closed 3 years ago

#19903 closed defect (fixed)

tor_tls_get_by_ssl is declared non-inline, then inline.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: openbsd, TorCoreTeam201608, 028-backport, review-group-7
Cc: Actual Points: 0
Parent ID: Points: 0
Reviewer: dgoulet Sponsor:

Description

In tortls.h, we declare tor_tls_by_ssl as non-inline. But in tortls.c, we declare it inline. This bugs the version of GCC that OpenBSD uses, and wasn't our intention.

Child Tickets

Change History (9)

comment:1 Changed 3 years ago by nickm

Owner: set to nickm
Severity: NormalMinor
Status: newaccepted

comment:2 Changed 3 years ago by nickm

Actual Points: 0
Keywords: openbsd TorCoreTeam201608 added
Status: acceptedneeds_review

Trivial fix in my branch bug19903_028. Please review.

comment:3 Changed 3 years ago by nickm

Keywords: 028-backport added

comment:4 Changed 3 years ago by cypherpunks

IMO it is cleaner to make the function non-inline instead of introducing another macro which is only used in one instance.

comment:5 Changed 3 years ago by nickm

Keywords: review-group-7 added

comment:6 Changed 3 years ago by dgoulet

Status: needs_reviewneeds_information

I have to agree with cypherpunks here, why is this inline at all? Not sure we need the STATIC_INLINE being used _once_ for a function that could be non-inline.

comment:7 Changed 3 years ago by dgoulet

Reviewer: dgoulet

comment:8 Changed 3 years ago by nickm

Status: needs_informationneeds_revision

agreed, dropping the inline is better.

comment:9 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_revisionclosed

Done in bug19903_028_v2. Merging that to 028 and forward.

Note: See TracTickets for help on using tickets.