Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#19905 closed defect (fixed)

make-test-network-all has never detected IPv6 on linux

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor: 0.2.7.3-rc
Severity: Normal Keywords: 029-proposed, easy, intro, TorCoreTeam201608
Cc: Actual Points: 0.1
Parent ID: Points: 0.2
Reviewer: Sponsor:

Description

When I wrote make-test-network-all, I tested IPv6 on OS X and BSD.
But it's never worked on Linux.

On BSD and OS X systems, we use:
ping6 -q -c 1 -o ::1

On Linux systems, we should use:
ping6 -q -c 1 -W 1 ::1

You'd think we could get away with:
ping6 -q -c 1 ::1
but BSD / OS X would hang forever on systems where IPv6 packets are dropped, and Linux is somewhat ambiguous about what happens in that case.

Over the long term, implementing checks like this in chutney might be a better idea.

Child Tickets

Change History (6)

comment:1 Changed 2 years ago by teor

I think the correct way to fix #19905 is to do the BSD ping6 and Linux ping6 checks separated by ||, with Linux first (as the majority platform), and each with stderr redirected to /dev/null.

comment:2 Changed 2 years ago by teor

Keywords: easy intro added

comment:3 Changed 2 years ago by teor

Actual Points: 0.1
Keywords: TorCoreTeam201609 added
Status: newneeds_review

See my branch bug19905 on https://github.com/teor2345/tor.git

comment:4 Changed 2 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

I've merged this to master, since testing can help us a lot and the patch is simple.

comment:5 Changed 2 years ago by nickm

Milestone: Tor: 0.3.0.x-finalTor: 0.2.9.x-final

comment:6 Changed 2 years ago by nickm

Keywords: TorCoreTeam201608 added; TorCoreTeam201609 removed
Note: See TracTickets for help on using tickets.