Opened 4 years ago

Closed 4 years ago

#19920 closed task (fixed)

Update audit notes to take preferences diff into account

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: GeorgKoppen201608, TorBrowserTeam201609R
Cc: Actual Points:
Parent ID: #19274 Points:
Reviewer: Sponsor: SponsorU


iSEC recommended to diff all.js between a vanilla ESR and Tor Browser which should be based on it to look for things that may have fallen through the cracks during feature review. We include firefox.js as well for this matter.

Doing this for ESR45 might have helped preventing #19890.

Child Tickets

Attachments (1)

0001-Bug-19920-Update-audit-notes-with-iSEC-suggestions.patch (1.3 KB) - added by gk 4 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 4 years ago by gk

Keywords: TorBrowserTeam201608R added; TorBrowserTeam201608 removed
Sponsor: SponsorU
Status: newneeds_review

An attached patch is up for review.

comment:2 Changed 4 years ago by gk

Keywords: TorBrowserTeam201609R added; TorBrowserTeam201608R removed

Moving review tickets to September

comment:3 Changed 4 years ago by arthuredelstein

Looks good to me. In the commit message "fell" should be "have fallen".

comment:4 Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks! This is commit 82f9fc99651afc6450f300d1ca78c8ff4af28a0d on master.

Note: See TracTickets for help on using tickets.