Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#19924 closed defect (fixed)

collector.properties: base url should not be in quotes

Reported by: iwakeh Owned by: iwakeh
Priority: Low Milestone: CollecTor 1.0.2
Component: Metrics/CollecTor Version:
Severity: Minor Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The default collector.properties base url should not be in quotes,
i.e.

--- a/src/main/resources/collector.properties
+++ b/src/main/resources/collector.properties
@@ -47,7 +47,7 @@ UpdateindexOffsetMinutes = 0
 ######## General Properties ########
 # The URL of this instance.  This will be the base URL
 # written to index.json
-InstanceBaseUrl = "https://collector.torproject.org"
+InstanceBaseUrl = https://collector.torproject.org
 # The target location for index.json and its compressed
 # versions index.json.gz, index.json.bz2, and index.json.xz
 IndexPath = .

This prevents the following in index.json

... ,"path":"\"https://collector.torproject.org\"",...

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by iwakeh

Status: newneeds_review

Please adjust this in the master branch.

comment:2 Changed 3 years ago by iwakeh

Milestone: CollecTor 1.1.0

comment:3 Changed 3 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Good catch! Pushed a fix to master. Closing.

comment:4 Changed 3 years ago by iwakeh

Milestone: CollecTor 1.1.0CollecTor 1.0.2

Added to appropriate milestone.

Note: See TracTickets for help on using tickets.