Opened 3 years ago

Closed 3 years ago

#19942 closed defect (fixed)

Fix mistake in comments in seccomp sandbox

Reported by: cypherpunks Owned by:
Priority: Low Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords:
Cc: Actual Points: 0
Parent ID: Points: 0
Reviewer: Sponsor:

Description

In src/common/sandbox.c, the comments for the sb_prctl() and sb_mprotect() functions both say they are for the fcntl64() syscall filter, probably because they were all copy pasted from that as a template.

--- src/common/sandbox.c
+++ src/common/sandbox.c
@@ -757,7 +757,7 @@
 }
 
 /**
- * Function responsible for setting up the fcntl64 syscall for
+ * Function responsible for setting up the prctl syscall for
  * the seccomp filter sandbox.
  *
  * NOTE: if multiple filters need to be added, the PR_SECCOMP parameter needs
@@ -778,7 +778,7 @@
 }
 
 /**
- * Function responsible for setting up the fcntl64 syscall for
+ * Function responsible for setting up the mprotect syscall for
  * the seccomp filter sandbox.
  *
  * NOTE: does not NEED to be here.. currently only occurs before filter; will

Child Tickets

Change History (2)

comment:1 Changed 3 years ago by nickm

Actual Points: 0
Milestone: Tor: 0.2.9.x-final
Points: 0
Status: newneeds_review

probably correct; trivial to review.

comment:2 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged; thanks!

Note: See TracTickets for help on using tickets.