Opened 3 years ago

Closed 3 years ago

#19956 closed defect (fixed)

"uptime" is wrong

Reported by: toralf Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

searching for a retired relay of mine :
https://atlas.torproject.org/#search/zwiebeltoralf
shows "Uptime" in the head of the table whereas it is the downtime (eg for the first enty)

https://atlas.torproject.org/#details/6A2F0A293B818706CCE1616D79A5C38FC5259F46

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by irl

Status: newaccepted

toralf: What do you think of strikethrough on times that are downtimes with a tooltip indicating it's downtime?

comment:2 Changed 3 years ago by toralf

yep, something in that direction.
The background of my whining is just to have at a glance a hint which entry is the current active server among the older entries.

comment:3 Changed 3 years ago by irl

Status: acceptedneeds_review

Ready for review. It could perhaps have been done with only one conditional if we hacked a CSS attribute in, but I don't think this is a dreadful approach, and it's a minimal change this way.

https://gitweb.torproject.org/user/irl/atlas.git/patch/?id=38f4d99f9f441716e99f9b5ae984c9db06ebd8c3

comment:4 Changed 3 years ago by karsten

Status: needs_reviewmerge_ready

Looks good to me! Thanks! :)

comment:5 Changed 3 years ago by irl

Resolution: fixed
Status: merge_readyclosed

Merged and deployed.

Note: See TracTickets for help on using tickets.