Option to disable gnupg version dependent changes in the Enigmail settings

When using Thunderbird with Enigmail and Torbirdy with the "modern" version of gnupg (2.1.15 in my case), Torbirdy modifies the options for Enigmail/gpg on every start of Thunderbird. Unfortunately some of the 'injected' options are not compatible with the new gpg version. It would be helpful (at least for the moment) to add an option that either completely disables this 'injection' or disables injecting the incompatible parameters. Afaik the incompatible options are no-try-dns-srv and http-proxy=socks5h://127.0.0.1:9150.

Trac:
Username: p.hansen

added component::applications/torbirdy owner::sukhbir priority::medium reporter::p.hansen resolution::fixed severity::normal status::closed type::enhancement labels

This seems to be related to #16935 (closed) and #13430 (closed).

The torified-dirmngr-compatibility branch on https://git-tails.immerda.ch/torbirdy.git adds an option that allows one to address this use case. I've applied these changes in Tails for our 3.0 version, that uses Modern GnuPG, and therefore is affected by this problem. Feedback welcome!

Trac:
Status: new to needs_review

Trac:
Cc: N/A to intrigeri

Replying to intrigeri:

The torified-dirmngr-compatibility branch on https://git-tails.immerda.ch/torbirdy.git adds an option that allows one to address this use case. This link goes to a page with No repositories found.

Yes, that's a bug in the web interface. But git clone https://git-tails.immerda.ch/torbirdy.git works.

Replying to intrigeri:

The torified-dirmngr-compatibility branch on https://git-tails.immerda.ch/torbirdy.git adds an option that allows one to address this use case. I've applied these changes in Tails for our 3.0 version, that uses Modern GnuPG, and therefore is affected by this problem. Feedback welcome!

Thanks for the patch!

This seems like a good solution in light of the GPG changes, compared to the HTTP proxy solution we have right now, which I feel is essentially broken.

Before I merge: is there a reason why the extensions.enigmail.agentAdditionalParam preferences were removed?

Replying to sukhbir:

This seems like a good solution in light of the GPG changes, compared to the HTTP proxy solution we have right now, which I feel is essentially broken.

Cool :)

Before I merge: is there a reason why the extensions.enigmail.agentAdditionalParam preferences were removed?

I don't remember. Looking at my branch again, I wonder if it was a mere mistake on my side, or if effectively extensions.enigmail.agentAdditionalParam is useless since we set the same prefs in the function my branch patches in chrome/content/preferences.js. I'll need to test my branch with GnuPG 1.x to confirm; I might be able to do that later this week, but if I can't it'll have to wait until my next time slot allocated to this topic (mid-March)... unless someone else beats me to it :)

Trac:
Status: needs_review to needs_information

Replying to intrigeri:

Replying to sukhbir:

This seems like a good solution in light of the GPG changes, compared to the HTTP proxy solution we have right now, which I feel is essentially broken.

Cool :)

Before I merge: is there a reason why the extensions.enigmail.agentAdditionalParam preferences were removed?

I don't remember. Looking at my branch again, I wonder if it was a mere mistake on my side, or if effectively extensions.enigmail.agentAdditionalParam is useless since we set the same prefs in the function my branch patches in chrome/content/preferences.js. I'll need to test my branch with GnuPG 1.x to confirm; I might be able to do that later this week, but if I can't it'll have to wait until my next time slot allocated to this topic (mid-March)... unless someone else beats me to it :)

I want to merge this patch but will wait for your confirmation about the removal of Enigmail preferences. Thanks for working on it! (I want to finish the next release when this is merged.)

Indeed, removing extensions.enigmail.agentAdditionalParam was wrong (it breaks the use case when my new pref is not enabled). But re-adding it prevents my new pref from taking effect, since pub.setEnigmailPrefs("tor") is not called in some places where it should. Now testing a fix, stay tuned :)

Updated the aforementioned branch. During my tests it fixes the problem this ticket is about, without breaking other use cases. Please review / merge / release :)

Trac:
Status: needs_information to needs_review

Merged in 09acfd09c465. Thank you for the patch!

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed