Opened 14 months ago

Closed 7 months ago

#19971 closed enhancement (fixed)

Option to disable gnupg version dependent changes in the Enigmail settings

Reported by: p.hansen Owned by: sukhbir
Priority: Medium Milestone:
Component: Applications/TorBirdy Version:
Severity: Normal Keywords:
Cc: intrigeri Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When using Thunderbird with Enigmail and Torbirdy with the "modern" version of gnupg (2.1.15 in my case), Torbirdy modifies the options for Enigmail/gpg on every start of Thunderbird. Unfortunately some of the 'injected' options are not compatible with the new gpg version.
It would be helpful (at least for the moment) to add an option that either completely disables this 'injection' or disables injecting the incompatible parameters.
Afaik the incompatible options are no-try-dns-srv and http-proxy=socks5h://127.0.0.1:9150.

Child Tickets

Change History (12)

comment:1 Changed 10 months ago by intrigeri

This seems to be related to #16935 and #13430.

comment:2 Changed 9 months ago by intrigeri

Status: newneeds_review

The torified-dirmngr-compatibility branch on https://git-tails.immerda.ch/torbirdy.git adds an option that allows one to address this use case. I've applied these changes in Tails for our 3.0 version, that uses Modern GnuPG, and therefore is affected by this problem. Feedback welcome!

comment:3 Changed 9 months ago by intrigeri

Cc: intrigeri added

comment:4 in reply to:  2 Changed 9 months ago by cypherpunks

Replying to intrigeri:

The torified-dirmngr-compatibility branch on https://git-tails.immerda.ch/torbirdy.git adds an option that allows one to address this use case.

This link goes to a page with No repositories found.

comment:5 Changed 9 months ago by intrigeri

Yes, that's a bug in the web interface. But git clone https://git-tails.immerda.ch/torbirdy.git works.

Last edited 9 months ago by intrigeri (previous) (diff)

comment:6 in reply to:  2 ; Changed 8 months ago by sukhbir

Replying to intrigeri:

The torified-dirmngr-compatibility branch on https://git-tails.immerda.ch/torbirdy.git adds an option that allows one to address this use case. I've applied these changes in Tails for our 3.0 version, that uses Modern GnuPG, and therefore is affected by this problem. Feedback welcome!

Thanks for the patch!

This seems like a good solution in light of the GPG changes, compared to the HTTP proxy solution we have right now, which I feel is essentially broken.

Before I merge: is there a reason why the extensions.enigmail.agentAdditionalParam preferences were removed?

comment:7 in reply to:  6 ; Changed 8 months ago by intrigeri

Status: needs_reviewneeds_information

Replying to sukhbir:

This seems like a good solution in light of the GPG changes, compared to the HTTP proxy solution we have right now, which I feel is essentially broken.

Cool :)

Before I merge: is there a reason why the extensions.enigmail.agentAdditionalParam preferences were removed?

I don't remember. Looking at my branch again, I wonder if it was a mere mistake on my side, or if effectively extensions.enigmail.agentAdditionalParam is useless since we set the same prefs in the function my branch patches in chrome/content/preferences.js. I'll need to test my branch with GnuPG 1.x to confirm; I might be able to do that later this week, but if I can't it'll have to wait until my next time slot allocated to this topic (mid-March)... unless someone else beats me to it :)

comment:8 in reply to:  7 Changed 8 months ago by sukhbir

Replying to intrigeri:

Replying to sukhbir:

This seems like a good solution in light of the GPG changes, compared to the HTTP proxy solution we have right now, which I feel is essentially broken.

Cool :)

Before I merge: is there a reason why the extensions.enigmail.agentAdditionalParam preferences were removed?

I don't remember. Looking at my branch again, I wonder if it was a mere mistake on my side, or if effectively extensions.enigmail.agentAdditionalParam is useless since we set the same prefs in the function my branch patches in chrome/content/preferences.js. I'll need to test my branch with GnuPG 1.x to confirm; I might be able to do that later this week, but if I can't it'll have to wait until my next time slot allocated to this topic (mid-March)... unless someone else beats me to it :)

I want to merge this patch but will wait for your confirmation about the removal of Enigmail preferences. Thanks for working on it! (I want to finish the next release when this is merged.)

comment:9 Changed 7 months ago by intrigeri

Indeed, removing extensions.enigmail.agentAdditionalParam was wrong (it breaks the use case when my new pref is not enabled). But re-adding it prevents my new pref from taking effect, since pub.setEnigmailPrefs("tor") is not called in some places where it should. Now testing a fix, stay tuned :)

comment:10 Changed 7 months ago by intrigeri

Updated the aforementioned branch. During my tests it fixes the problem this ticket is about, without breaking other use cases. Please review / merge / release :)

comment:11 Changed 7 months ago by intrigeri

Status: needs_informationneeds_review

comment:12 Changed 7 months ago by sukhbir

Resolution: fixed
Status: needs_reviewclosed

Merged in 09acfd09c465. Thank you for the patch!

Note: See TracTickets for help on using tickets.