Opened 3 years ago

Closed 3 years ago

#19972 closed defect (fixed)

prop224: Proposal fixes from implementation of HSDir support

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: proposal, tor-hs, review-group-8
Cc: Actual Points: 0.1
Parent ID: #17238 Points: 0.5
Reviewer: Sponsor: SponsorR-must

Description

With the implementation work of #17238, we ended up changing small pieces of proposal 224. This is the ticket to address those.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by dgoulet

Actual Points: 0.1
Status: newneeds_review

See top two commits in branch ticket19972_01

comment:2 Changed 3 years ago by asn

We should also mention the prefixed descriptor signature here. Here is what I currently do:

/* Prefix required to compute/verify HS desc signatures */
#define hs_desc_signature_prefix "Tor onion service descriptor sig v3"
...
    if (ed25519_sign_prefixed(&sig,
                              (const uint8_t *) encoded_str, encoded_len,
                              hs_desc_signature_prefix,
                              &desc->plaintext_data.signing_kp) < 0) {

comment:3 Changed 3 years ago by asn

Your changes look good to me David.

I also pushed a commit myself to ticket19972_01 in my repo, that addresses comment:2 .

Let me know if you like it and I will push all this stuff upstream.

comment:4 Changed 3 years ago by dgoulet

Status: needs_reviewmerge_ready

All good! Feel free to update the upstream! Thx!

comment:5 Changed 3 years ago by nickm

Keywords: review-group-7 added

comment:6 Changed 3 years ago by nickm

Keywords: review-group-8 added; review-group-7 removed

comment:7 Changed 3 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged, but see 3cc0e9b3a82435404f00036bd11b33689cc98080

Note: See TracTickets for help on using tickets.