Opened 3 years ago

Last modified 21 months ago

#19980 new enhancement

Use OpenSSL 1.1.0 X5519 in Tor when available (if it's good)

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: openssl110 performance tor-relay tor-client crypto
Cc: isis Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

OpenSSL 1.1.0 says it now has X5519 support. If it's done well, we should consider using it in Tor when linking against OpenSSL 1.1.0.

Child Tickets

Change History (8)

comment:1 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:2 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:3 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:4 Changed 22 months ago by nickm

Keywords: performance tor-relay tor-client crypto added
Type: defectenhancement

comment:5 Changed 22 months ago by isis

Cc: isis added

comment:6 Changed 22 months ago by isis

The x25519 code in OpenSSL_1_1_0-stable is the same as in BoringSSL, fwiw. Upon cursory review, it appears to be a slightly cleaned up curve25519-donna (what we're using).

comment:7 Changed 22 months ago by yawning

Does it have a table driven scalar basepoint multiply?

comment:8 in reply to:  7 Changed 21 months ago by isis

Replying to yawning:

Does it have a table driven scalar basepoint multiply?


Yes, in crypto/ec/curve25519.c:

/* k25519Precomp[i][j] = (j+1)*256^i*B */
static const ge_precomp k25519Precomp[32][8] = {
[…]
}
Note: See TracTickets for help on using tickets.