Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#2000 closed defect (fixed)

rate-limit "Your application is giving Tor only an IP address" warning

Reported by: Sebastian Owned by: Sebastian
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We should rate-limit this to once every 5 seconds or so. Rate-limiting it to be sent less often might confuse users into believing that it is a one-time thing that they don't need to worry about (or worse, that they fixed it by changing a setting in their proxy/browser), but spamming the log with one message per request is excessive.

I'll have a fix in a bit.

Child Tickets

Change History (5)

comment:1 Changed 9 years ago by Sebastian

Status: newneeds_review

bug2000 in my repo

comment:2 Changed 9 years ago by nickm

Milestone: Tor: 0.2.2.x-final

Moving to 0.2.2.x-final; this should be a small thing, and it seems worth doing.

I'd like to see the code here turn into a separate function, if possible. I can do that (and rebase it back onto 0.2.2) if you don't have time.

comment:3 Changed 9 years ago by nickm

See branch "bug2000_nm_022"

comment:4 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged it.

comment:5 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.