Opened 3 years ago

Closed 3 years ago

#20002 closed defect (implemented)

Never include non-Valid nodes in consensus.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: prop272, TorCoreTeam201608, review-group-8
Cc: Actual Points: .1
Parent ID: #20001 Points: .1
Reviewer: Sponsor:

Description

Right now, we don't include non-Running nodes. Let's make it so we never include non-Valid nodes either.

Child Tickets

Change History (9)

comment:1 Changed 3 years ago by nickm

This is part of proposal 272.

comment:2 Changed 3 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:3 Changed 3 years ago by nickm

Actual Points: .1
Keywords: prop272 added; needs-proposal removed
Status: acceptedneeds_review

See branch "ticket20002" in my public repository.

comment:4 Changed 3 years ago by nickm

Keywords: TorCoreTeam201608 added

comment:5 Changed 3 years ago by nickm

Keywords: review-group-8 added

comment:6 Changed 3 years ago by andrea

Status: needs_reviewmerge_ready

This looks just fine to me.

comment:7 Changed 3 years ago by nickm

Merged! Thanks for the review.

comment:8 Changed 3 years ago by nickm

(Actually hang on. Not merged yet. Running some tests first)

comment:9 Changed 3 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

Okay. Now merged for real. Pfew!

Note: See TracTickets for help on using tickets.