Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#20014 closed defect (fixed)

GETINFO version in torspec is inconsistent with the implementation

Reported by: teor Owned by: jryans
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy, doc, tor-03-unspecified-201612, tor-spec
Cc: jryans@… Actual Points:
Parent ID: Points: 0.2
Reviewer: Sponsor:

Description

The torspec description of GETINFO version is:

    "version" -- The version of the server's software, including the name
      of the software. (example: "Tor 0.0.9.4")

But tor responds:

GETINFO version
250-version=0.2.8.6 (git-4d217548e3f05569)
250 OK

The "Tor " is missing from the response. We should remove it from the spec.

Child Tickets

Change History (9)

comment:1 Changed 3 years ago by nickm

I think we should replace the text to say that "the name of the software, if absent, should be assumed to be Tor." Otherwise there's no reasonable way for compatible implementations to comply.

comment:2 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:3 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:4 Changed 3 years ago by jryans

Cc: jryans@… added
Owner: set to jryans
Status: newassigned

comment:5 Changed 3 years ago by jryans

Status: assignedneeds_review

comment:6 Changed 3 years ago by teor

Milestone: Tor: unspecifiedTor: 0.3.0.x-final
Status: needs_reviewmerge_ready

Looks good to me - thanks!

Since this is a spec change, let's get it in the latest release.

comment:7 Changed 3 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

Sure; merged.

comment:8 Changed 2 years ago by teor

Keywords: tor-spec added

Consistently use tor-spec across all tickets (add tor-spec).

comment:9 Changed 2 years ago by teor

Keywords: torspec removed

Consistently use tor-spec across all tickets (remove torspec).

Note: See TracTickets for help on using tickets.