Opened 4 years ago

Closed 3 years ago

#20028 closed defect (worksforme)

Fix typos in tor-spec.txt [circID -> CircID]

Reported by: twim Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Child Tickets

Attachments (1)

0001-Fix-typo-in-tor-spec.txt-circID-CircID-g.patch (2.6 KB) - added by twim 4 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 4 years ago by twim

Status: newneeds_review

comment:2 Changed 4 years ago by nickm

Keywords: review-group-11 added
Milestone: Tor: 0.3.0.x-final

comment:3 Changed 4 years ago by nickm

I don't think this is a typo or a bug; IMO both capitalizations are fine. (Somebody let me know if I'm wrong though)

comment:4 Changed 4 years ago by dgoulet

Status: needs_reviewneeds_information

My two cents. I would say that for an official spec, having a standard of syntax especially for technical terms, having it uniform helps avoid any possible confusion and helps the grepping! That's also because of my OCD ;).

Food for thought: in tor code, we have two occurrences of CircID, one in a comment and the other in a log message where we have much more circID. So, if we are serious about fixing this, I would pick one standard and fix it in all spec/proposals and tor code. It's not that many but if the effort to standardize those is made, I think it's worth merging in the end.

I would pick CircID as it's the one we use to define the cell ABI in the spec.

comment:5 Changed 4 years ago by nickm

Keywords: review-group-11 removed

comment:6 Changed 3 years ago by dgoulet

Keywords: triage-out-030-201612 added
Milestone: Tor: 0.3.0.x-finalTor: unspecified

Triaged out on December 2016 from 030 to Unspecified.

comment:7 Changed 3 years ago by nickm

Keywords: triage-out-030-201612 removed

comment:8 Changed 3 years ago by nickm

Resolution: worksforme
Status: needs_informationclosed
Note: See TracTickets for help on using tickets.