Changes between Initial Version and Version 1 of Ticket #20030, comment 7


Ignore:
Timestamp:
Sep 26, 2016, 8:07:42 PM (3 years ago)
Author:
dcf
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #20030, comment 7

    initial v1  
    11attachment:0001-Ignore-SIGPIPE-in-meek-client-torbrowser.patch works around the problem by ignoring SIGPIPE. I found I had to call signal.Notify with a dummy channel; calling signal.Ignore didn't work.
    22
    3 I think we're fine with ignoring logging errors. The log package ignores them anyway. I'm a bit worried that because Go's SIGPIPE rule affects both stdin and stdout, something might go wrong with the PT negotiation on stdout. goptlib doesn't report errors that may arise from its writes to stdout. But I couldn't think of a way it would cause a problem, and even if it does it should be rare.
     3I think we're fine with ignoring logging errors. The log package ignores them anyway. I'm a bit worried that because Go's SIGPIPE rule affects both stdout and stderr, something might go wrong with the PT negotiation on stdout. goptlib doesn't report errors that may arise from its writes to stdout. But I couldn't think of a way it would cause a problem, and even if it does it should be rare.
    44
    55arlolra, if you want to test this, you can just `go build` in the meek-client-torbrowser subdirectory, then copy meek-client-torbrowser into your bundle directory.