Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20040 closed defect (fixed)

fix MAR file generation to account for packed HTTPS Everywhere

Reported by: mcs Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201608R
Cc: tbb-team, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Starting with version 5.2.2, HTTPS Everywhere is no longer an unpacked extension. We need to make some changes to the MAR file generation scripts under tools/update-packaging to account for this change.

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by gk

Cc: gk added

comment:2 Changed 3 years ago by mcs

Keywords: TorBrowserTeam201608R added
Status: newneeds_review

It is somewhat messy to handle all of the possible situations. Here is a patch that Kathy and I developed:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug20040-01&id=082d1c5e03617458f366b597256597bbde079889
It should be OK to merge this now because it handles the current situation (unpacked HTTPS-E -> unpacked) as well as the new possibilities (unpacked -> packed and packed -> packed).

comment:3 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. This is commit 082d1c5e03617458f366b597256597bbde079889 on tor-browser-45.3.0esr-6.5-1.

I guess we want to have that for the stable as well? Did you test that and verified that the fix worked properly in that particular case?

comment:4 in reply to:  3 Changed 3 years ago by mcs

Replying to gk:

Looks good to me. This is commit 082d1c5e03617458f366b597256597bbde079889 on tor-browser-45.3.0esr-6.5-1.

Thanks.

I guess we want to have that for the stable as well? Did you test that and verified that the fix worked properly in that particular case?

I think we want this on stable. Kathy and I tested by running through all of the scenarios and verifying that the MAR table of contents plus manifest looked correct.

comment:5 Changed 3 years ago by gk

Okay, this is commit f800760546f5912d5aef5ca4e56b9e3fd62df8f9 on tor-browser-45.3.0esr-6.0-1.

Note: See TracTickets for help on using tickets.