Opened 3 years ago

Closed 3 years ago

#20042 closed enhancement (implemented)

Always log BUG messages from the unit tests

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: TorCoreTeam201608
Cc: Actual Points: 0.3
Parent ID: #19999 Points: 0.3
Reviewer: dgoulet Sponsor: SponsorS-can

Description

Our log_test_helpers.c code is great, but it suppresses log messages that we would like to see!

Also, we should always see BUG messages unless we're specifically suppressing them.

This could be sponsorS (testing) or sponsorU (since I need it to test the link handshake improvements of #15555)

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 3 years ago by nickm

Status: acceptedneeds_review

Have a look at branch log_test_improvements in my public repository. It also fixes #20041.

comment:3 Changed 3 years ago by dgoulet

Actual Points: .30.3
Component: - Select a componentCore Tor/Tor
Points: .30.3
Reviewer: dgoulet
Sponsor: SponsorS-can
Status: needs_reviewmerge_ready

Code looks good to me. I like this feature especially to have BUG one by default (unless explicitly suppressed), very important to catch code flow error which those BUG() are suppose to help with.

comment:4 Changed 3 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged; thanks for the review!

Note: See TracTickets for help on using tickets.