Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20079 closed enhancement (fixed)

Change log thresholds from TRACE to INFO

Reported by: karsten Owned by:
Priority: Medium Milestone: CollecTor 1.0.2
Component: Metrics/CollecTor Version:
Severity: Normal Keywords:
Cc: iwakeh Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Turns out that CollecTor's torperf module is rather chatty when it comes to logging. In the past few days it produced 39G of logs, of which only 876k were higher than TRACE and DEBUG. This didn't come to my attention earlier, because I simply didn't log those lines before upgrading to latest master. I think this is rather surprising for new CollecTor operators, and I wonder if we should change the default from TRACE to INFO. If an operator wants to debug a problem, they can always switch to a lower log level.

Suggested patch:

diff --git a/src/main/resources/logback.xml b/src/main/resources/logback.xml
index 2d8a1ce..82e52ab 100644
--- a/src/main/resources/logback.xml
+++ b/src/main/resources/logback.xml
@@ -40,6 +40,9 @@
         <maxFileSize>1MB</maxFileSize>
       </timeBasedFileNamingAndTriggeringPolicy>
     </rollingPolicy>
+    <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
+      <level>INFO</level>
+    </filter>
   </appender>
 
   <appender name="FILEBRIDGEDESCS" class="ch.qos.logback.core.FileAppender">
@@ -49,7 +52,7 @@
     </encoder>
 
     <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
-      <level>TRACE</level>
+      <level>INFO</level>
     </filter>
   </appender>
 
@@ -60,7 +63,7 @@
     </encoder>
 
     <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
-      <level>TRACE</level>
+      <level>INFO</level>
     </filter>
   </appender>
 
@@ -71,7 +74,7 @@
     </encoder>
 
     <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
-      <level>TRACE</level>
+      <level>INFO</level>
     </filter>
   </appender>
 
@@ -82,7 +85,7 @@
     </encoder>
 
     <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
-      <level>TRACE</level>
+      <level>INFO</level>
     </filter>
   </appender>
 

What do you think?

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by iwakeh

Status: newmerge_ready

Sure, that's very reasonable and should be done soon.
(Maybe add this adaption to #19016?)

comment:2 Changed 3 years ago by karsten

Great, will do! But what do you mean by "add this adaption to #19016"? Do you mean the usual conflict resolution, or does the patch above need to change in any way after applying the #19016 patch? Thanks!

comment:3 Changed 3 years ago by iwakeh

I thought it might be easier to add the logback config changes as a commit on top of the changes for #19016 than to merge this and the logging config changes in #19016. Either way is fine.

comment:4 Changed 3 years ago by karsten

Sure, sounds good. Will merge as soon as #19016 is in.

comment:5 Changed 3 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Merged to master! Thanks! Closing.

comment:6 Changed 3 years ago by iwakeh

Milestone: CollecTor 1.1.0CollecTor 1.0.2

Added to appropriate milestone.

Note: See TracTickets for help on using tickets.