Opened 3 years ago

Last modified 9 months ago

#20091 new enhancement

Add a required version setting to chutney (or to chutney networks)

Reported by: teor Owned by:
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords: easy?
Cc: egypcio Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor:

Description

This is important when we add a new chutney feature or network (like in #20069), then make Tor depend on it.

One way we could do this is to check the exit status of chutney in chutney/chutney, and logging the appropriate message if it fails.

Another way is for the Tor chutney tests to set CHUTNEY_MIN_VERSION, and then chutney warns if it's not that version. This would actually require us to version chutney.

Child Tickets

TicketTypeStatusOwnerSummary
#20344enhancementnewDo chutney releases with semantic versioning

Change History (9)

comment:1 Changed 3 years ago by teor

In tools/test-network.sh, this should be --require-version, as that matches trunnel.

comment:2 Changed 3 years ago by teor

meejah recommends on IRC:

looks like "from pkg_resources import parse_version" is what you want
then: parse_version('0.1.2.3') < parse_version('0.1.2.4') will be True

comment:3 Changed 3 years ago by teor

This is partially fixed in 6e9658c, which reminds the user to update when chutney can't parse an option. (Of course, this only works for *new* options.)

comment:4 in reply to:  3 ; Changed 3 years ago by cypherpunks

Replying to teor:

This is partially fixed in 6e9658c, which reminds the user to update when chutney can't parse an option. (Of course, this only works for *new* options.)

There is a typo in the update message.

comment:5 in reply to:  4 Changed 3 years ago by teor

Replying to cypherpunks:

Replying to teor:

This is partially fixed in 6e9658c, which reminds the user to update when chutney can't parse an option. (Of course, this only works for *new* options.)

There is a typo in the update message.

Thanks, fixed in 656b5d8.

comment:6 Changed 2 years ago by teor

Summary: When chutney fails, make the last message "Do you have the latest chutney version from ...?"Add a required version setting to chutney (or to chutney networks)

Renaming to clarify remaining work.

comment:7 Changed 23 months ago by teor

Owner: teor deleted
Status: newassigned

Disowning tickets I don't intend to work on in the next 6 months.

comment:8 Changed 23 months ago by teor

Status: assignednew

Mark all tickets that are assigned to nobody as "new".

comment:9 Changed 9 months ago by egypcio

Cc: egypcio added
Note: See TracTickets for help on using tickets.