Opened 2 years ago

Last modified 17 months ago

#20098 assigned enhancement

Make reference checker more accurate

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/CollecTor Version:
Severity: Normal Keywords: metrics-2018
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

As of February this year we're using a reference checker to spot missing descriptors that reads files in recent/relay-descriptors/ and warns if too many referenced descriptors cannot be found.

However, our reference checker has been too noisy for me to pay much attention.

I didn't look at the logs in detail yet, but I came up with a possible improvement: we should only count an extra-info descriptor as missing if the referencing server descriptor is referenced from a consensus or vote. This is supposed to exclude all extra-info descriptors that are referenced from server descriptors uploaded to the directory authorities by bogus relays without also uploading the corresponding extra-info descriptors.

Maybe there are other tweaks that make these warnings more accurate and again worth checking by the operator.

Child Tickets

Change History (4)

comment:1 Changed 2 years ago by iwakeh

The trouble causing relay in #19170 named SweTor247 is and was referenced by consensus (the Sep 4, 2016 consensus for example).

comment:2 Changed 2 years ago by karsten

Yes, but only a single server descriptor was referenced from the consensus. That means we'd see a single warning, not a few hundred. More precisely, we're assigning points to each missing descriptor and only putting out a warning if total points pass a certain threshold. So, not warning about n-1 of SweTor247's missing extra-info descriptors would already help a lot.

comment:3 Changed 17 months ago by karsten

Keywords: metrics-2018 added

comment:4 Changed 17 months ago by karsten

Owner: set to metrics-team
Status: newassigned
Note: See TracTickets for help on using tickets.