Opened 3 years ago

Closed 3 years ago

#20112 closed defect (fixed)

test_with_ephemeral_hidden_services_basic_auth [FAILURE]

Reported by: toralf Owned by: atagar
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Stem Version: Tor: 0.2.9.2-alpha
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

get this with 0.2.9.x series :

Running tests...

  control.controller.test_with_ephemeral_hidden_services_basic_auth... failed (0.02s)
test_with_ephemeral_hidden_services_basic_auth               [FAILURE]

======================================================================
FAIL: test_with_ephemeral_hidden_services_basic_auth
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tfoerste/devel/stem/test/runner.py", line 127, in wrapped
    return func(self, *args, **kwargs)
  File "/home/tfoerste/devel/stem/test/runner.py", line 144, in wrapped
    return func(self, *args, **kwargs)
  File "/home/tfoerste/devel/stem/test/integ/control/controller.py", line 688, in test_with_ephemeral_hidden_services_basic_auth
    self.assertEqual(['bob'], response.client_auth.keys())  # newly created credentials were only created for bob
AssertionError: ['bob'] != dict_keys(['bob'])

----------------------------------------------------------------------
Ran 1 test in 0.019s

FAILED (failures=1)

at a hardened 64bit stable Gentoo desktop. The hardened feature shouldn't play a big role here, neither in pax.log nor in grsec.log are any suspicious entries.

A 1st attempt to bisect gives tor-0.2.9.0-root-769-g70fd23f - and I checked twice that that the previous commit is good and that commit is bad - but I don't have any clue how that commit id should harm the test case.

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by nickm

Milestone: Tor: 0.2.9.x-final

Weird -- 70fd23f is just a version bump.

comment:2 Changed 3 years ago by atagar

Component: Core TorCore Tor/Stem
Owner: set to atagar

Interesting! Actually, this looks like a Stem testing bug to me, swapping this over to my component.

I'm having some difficulty reproing this but I think I see the fix. toralf, if you change 'stem/test/integ/control/controller.py' line 688 from...

self.assertEqual(['bob'], response.client_auth.keys())

... to...

self.assertEqual(['bob'], list(response.client_auth.keys()))

... does it work?

comment:3 Changed 3 years ago by toralf

bingo - the test passes fine now.

(In fact I bisected 3 different intervalls before to ensure that I do really blame the code and not myself to be a moron due to the fact, that the "bad" commit was so harmless :-D ...)

Last edited 3 years ago by toralf (previous) (diff)

comment:4 Changed 3 years ago by atagar

Resolution: fixed
Status: newclosed

Great! Fix pushed, thanks for the catch!

https://gitweb.torproject.org/stem.git/commit/?id=be9cc74

Note: See TracTickets for help on using tickets.