Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20118 closed enhancement (fixed)

Don't unpack HTTPS Everywhere anymore while bundling Tor Browser

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Normal Keywords: tbb-usability, GeorgKoppen201609, TorBrowserTeam201609R
Cc: boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We ship support for unpacked HTTPS Everywhere soon. As it does not need to be unpacked anymore (since 5.2.2) we should not do this either in our bundling step.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by gk

Owner: changed from erinn to tbb-team
Status: newassigned

comment:2 Changed 3 years ago by gk

Cc: boklm added
Keywords: GeorgKoppen201609 TorBrowserTeam201609R added; TorBrowserTeam201609 removed
Status: assignedneeds_revision

bug_20118_v3 in my public tor-browser-bundle repo (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_20118_v3&id=46a041e6573c0abbc074e7865a700f383edbc8c1) has a proposed fix up for review.

comment:3 Changed 3 years ago by boklm

I did not try building with this patch, but the changes look correct.

comment:4 Changed 3 years ago by mcs

r=mcs
I did not try to build with these changes either but they look good.

comment:5 Changed 3 years ago by gk

Resolution: fixed
Status: needs_revisionclosed

Okay, I finally went with bug_20188_v5 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_20118_v5&id=ae5f3f9f9bb12a0e07d268262c6e5b8e3b0baf88) after I found issues while testing. Applied to master as commit ae5f3f9f9bb12a0e07d268262c6e5b8e3b0baf88.

comment:6 Changed 3 years ago by gk

That got picked up for 6.0.6 with commit b373d46c616682000ff07029eaa4a113e29b286e on maint-6.0.

Note: See TracTickets for help on using tickets.