Opened 4 years ago

Closed 4 years ago

#20133 closed task (fixed)

Remove patch for building OpenSSL reproducible

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: tbb-gitian, GeorgKoppen201609, TorBrowserTeam201609R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


We have a patch in our patch set for building OpenSSL reproducible. This got upstreamed into 1.0.2 and we should therefore remove it. Otherwise the builds are broken.

Child Tickets

Change History (4)

comment:1 Changed 4 years ago by gk

The nightly builds fail with

make[1]: Leaving directory `/home/debian/build/libevent'
+ cd ..
+ tar xzf openssl.tar.gz
+ cd openssl-1.0.2h openssl-Make-build-reproducible.patch
+ patch -p1
patching file crypto/cversion.c
Hunk #1 FAILED at 68.
1 out of 1 hunk FAILED -- saving rejects to file crypto/cversion.c.rej

comment:2 Changed 4 years ago by gk

Keywords: TorBrowserTeam201609R added; TorBrowserTeam201609 removed
Status: newneeds_review

comment:3 Changed 4 years ago by boklm

The commit in branch bug_20133 looks good to me.

comment:4 Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Fixed on master (commit 4e2d9e7d4a0e0485ee5a5654e98c7262b9e6c03c) and hardened-builds (commit 4023bc26f3a371dbdadc7659eb511c6d2a5b4d5c).

Note: See TracTickets for help on using tickets.