Changes between Initial Version and Version 1 of Ticket #20147, comment 8


Ignore:
Timestamp:
Dec 7, 2016, 12:48:51 PM (3 years ago)
Author:
gk
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #20147, comment 8

    initial v1  
    1 Sorry for the long time before I got to your patch. Overall it looks good to me. It seems you are using a bunch of bashisms. This is fine with me n general but please don't declare this as a script for the Bourne shell then (which we/you do with `#!/bin/sh`).
     1Sorry for the long time before I got to your patch. Overall it looks good to me. It seems you are using a bunch of bashisms. This is fine with me in general but please don't declare this as a script for the Bourne shell then (which we/you do with `#!/bin/sh`).