Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20160 closed defect (fixed)

Backport - MP3 playback is broken

Reported by: bugzilla Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: tbb-crash, tbb-easy, tbb-usability, TorBrowserTeam201609R, GeorgKoppen201609
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When playing MP3, seekbar goes to the end and total duration is not displayed:
https://bugzilla.mozilla.org/show_bug.cgi?id=1263334
and its deps:
Wrong calculation of duration for some MP3 files
SIGFPE in [@mozilla::mp3::MP3TrackDemuxer::OffsetFromFrameIndex]

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by gk

Keywords: TorBrowserTeam201609 added
Priority: MediumHigh
Severity: NormalMajor

comment:2 Changed 3 years ago by gk

Keywords: TorBrowserTeam201609R GeorgKoppen201609 added; TorBrowserTeam201609 removed
Status: newneeds_review

bug_20160 (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_20160) has backports of three patches fixing both the crash and the related usability bugs (seekbar goes to the end/total duration is not displayed).

comment:3 Changed 3 years ago by mcs

r=mcs
These changes look OK to me.

comment:4 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Okay, let's test that in the next alpha. I applied all three Mozilla patches to tor-browser-45.4.0esr-6.5-1 (commit 57bdfc8fded25c4d6952208e7e2561509d57f7c5, 2b459feaa5713f0b2c3d6595e677290cdcc8f9ca, and 6715852d4487a4b3176c70f34358f5894954bbe2).

comment:5 Changed 3 years ago by gk

Keywords: tbb-usability added
Note: See TracTickets for help on using tickets.