Opened 3 years ago

Closed 3 years ago

#20176 closed defect (implemented)

current_consensus is an unmarked hazard

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: review-group-10
Cc: Actual Points:
Parent ID: #20191 Points: 0.1
Reviewer: dgoulet Sponsor:

Description

current_md_consensus is a static variable.
current_ns_consensus is a static variable.

#define current_consensus                                       \
  (we_use_microdescriptors_for_circuits(get_options()) ?        \
   current_md_consensus : current_ns_consensus)

We should at the very least rename this to a CURRENT_CONSENSUS macro.

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by nickm

Status: newneeds_review

bug20176 is what I'd have in mind, though we shouldn't merge it till after #20103, and it will need a check-spaces cleanup.

comment:2 Changed 3 years ago by nickm

Now see bug20176_v2. I rebased it and simplified some of the code a little harder.

comment:3 Changed 3 years ago by nickm

Parent ID: #20191

comment:4 Changed 3 years ago by nickm

Owner: set to nickm
Status: needs_reviewaccepted

comment:5 Changed 3 years ago by nickm

Status: acceptedneeds_review

comment:6 Changed 3 years ago by nickm

Keywords: review-group-10 added

Add needs_review 0.2.9 tickets, plus ones that have been in needs_revision for less than a week, to review-group-10.

comment:7 Changed 3 years ago by dgoulet

Points: .10.1
Reviewer: dgoulet
Status: needs_reviewmerge_ready

lgtm;

Passes all tests here.

comment:8 Changed 3 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

great; merged!

Note: See TracTickets for help on using tickets.