Opened 3 years ago

Closed 3 years ago

#20182 closed defect (fixed)

Recreating the ja .mar files on OS X is not working correctly

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-gitian, TorBrowserTeam201610R
Cc: boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Doing the preparations according to the fix for #19410 does not take the special treatment of the ja locale into account. Thus, neither the full nor the incremental MAR file are properly created.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by gk

Keywords: TorBrowserTeam201610 added; TorBrowserTeam201609 removed

Moving tickets to October.

comment:2 Changed 3 years ago by boklm

Keywords: TorBrowserTeam201610R added; TorBrowserTeam201610 removed
Status: newneeds_review

The branch bug_20182 in my git repo should fix this:
https://gitweb.torproject.org/user/boklm/tor-browser-bundle.git/commit/?h=bug_20182

When running dmg2mar from this branch on 6.5a3 I now have this:

$ ../../tools/dmg2mar 
Starting TorBrowser-6.5a3-osx64_ja.dmg -> tor-browser-osx64-6.5a3_ja-JP-mac.mar
Finished TorBrowser-6.5a3-osx64_ja.dmg -> tor-browser-osx64-6.5a3_ja-JP-mac.mar

comment:3 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good and merged to master (commit 3993fb0ee7624b8c0daaefcd9f08d1ccf0a048e1).

Note: See TracTickets for help on using tickets.