Opened 3 years ago

Closed 3 years ago

#20183 closed defect (fixed)

Only recreate the incremental OS X MAR files if we need to take OS X signatures into account

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-gitian, TorBrowserTeam201610R
Cc: boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In the wake of recreating the .mar files for #19410 there is no need to do so for non-OS X platforms. But currently this is done.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by gk

Summary: Only recreate the incremental OSX MAR files if we need to take OS X signatures into accountOnly recreate the incremental OS X MAR files if we need to take OS X signatures into account

comment:2 Changed 3 years ago by boklm

Keywords: TorBrowserTeam201610R added
Status: newneeds_review

The branch bug_20183 in my git repository has a patch for this:
https://gitweb.torproject.org/user/boklm/tor-browser-bundle.git/commit/?h=bug_20183

I checked that when running make dmg2mars-alpha on this branch, only the OSX mar files a recreated.

comment:3 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. This is commit ac9c992cae2078c866b67341d929c61fe54f5437 on tor-browser-bundle master.

Note: See TracTickets for help on using tickets.