Opened 3 years ago

Closed 3 years ago

#20186 closed enhancement (fixed)

"make update-responses" should extract mar tools

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201611R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Since fixing #19528 the make update-responses command is using the mar command to extract a mar file to get its build id. It works if the mar tools were previously extracted and added to the PATH before running make update-responses, but it fails otherwise. The update_responses script should extract the mar tools itself so it does not need to be done manually.

Child Tickets

Attachments (1)

0001-Bug-20186-extract-mar-tools-when-creating-update-res.patch (944 bytes) - added by boklm 3 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 3 years ago by boklm

Keywords: TorBrowserTeam201611R added
Status: newneeds_review

I attached a patch to fix this.

comment:2 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Fixed with commits (03c0e4bb0fd295e16a72d755a52e74c7e73ce965 and 3b26471de9544deaf9b34ed5e351a2f7ef9b5f3c) (on master and hardened-builds).

Note: See TracTickets for help on using tickets.