Opened 3 years ago

Last modified 2 years ago

#20191 new defect

Prevent a recurrence of #20103

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client debugging technical-debt bug-prevention
Cc: Actual Points:
Parent ID: Points: 2
Reviewer: Sponsor:

Description

On #20103, Roger sensibly asks:

Assuming for the moment that it is the right patch though: are there things we should do to remove this trap for future developers? Maybe a huge comment would be an easy first step? And maybe "precompute the answer to what that macro was about, and locate where in the code the answer might change, and only change it then" as another step?

Yes, let's.

Child Tickets

TicketStatusOwnerSummaryComponent
#20176closednickmcurrent_consensus is an unmarked hazardCore Tor/Tor

Change History (8)

comment:1 Changed 3 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 3 years ago by dgoulet

Status: acceptedneeds_information

Child is done? We have more tickets in mind for this or closing this is a safe bet?

comment:3 Changed 3 years ago by nickm

Milestone: Tor: 0.2.9.x-finalTor: 0.3.0.x-final
Status: needs_informationnew

It would also be possible to make it harder for anything to accidentally mess with the routerstatus_t pointers in the nodelist between freeing the old networkstatus and making everything point to the new on.

Also it could be possible to change the order in which the two operations happen.

Also we could look at the stuff that caused the bug, and see if it really needed to look at the networkstatus list at all.

Not in 029 though.

comment:4 Changed 3 years ago by dgoulet

Keywords: triage-out-030-201612 added
Milestone: Tor: 0.3.0.x-finalTor: 0.3.1.x-final

Triaged out on December 2016 from 030 to 031.

comment:5 Changed 3 years ago by nickm

Milestone: Tor: 0.3.1.x-finalTor: unspecified
Owner: nickm deleted
Status: newassigned

comment:6 Changed 3 years ago by nickm

Status: assignednew

comment:7 Changed 3 years ago by nickm

Keywords: triage-out-030-201612 removed

comment:8 Changed 2 years ago by nickm

Keywords: tor-client debugging technical-debt bug-prevention added
Points: .22
Note: See TracTickets for help on using tickets.