Opened 3 years ago

Closed 3 years ago

#20201 closed defect (fixed)

Update docstring for parse_bridge_line() in src/or/config.c

Reported by: isis Owned by:
Priority: Very Low Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Trivial Keywords: doc
Cc: Actual Points: 1
Parent ID: Points: 1
Reviewer: Sponsor:

Description

It's pretty out-of-date.

 /** Read the contents of a Bridge line from <b>line</b>. Return 0
  * if the line is well-formed, and -1 if it isn't. If
  * <b>validate_only</b> is 0, and the line is well-formed, then add
  * the bridge described in the line to our internal bridge list.
  *
  * Bridge line format:
  * Bridge [transport] IP:PORT [id-fingerprint] [k=v] [k=v] ...
  */
 /* private */ bridge_line_t *
 parse_bridge_line(const char *line)

The return types are totally different that specified, and the function does not add a well-formed bridge line to the internal bridge list as stated.

Child Tickets

Change History (2)

comment:1 Changed 3 years ago by isis

Milestone: Tor: 0.2.9.x-final
Status: newneeds_review

A shiny new description of the actual behaviour is in my bug20201 branch.

comment:2 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged; thanks!

Note: See TracTickets for help on using tickets.