Opened 4 years ago
Closed 4 years ago
#20217 closed enhancement (fixed)
Make sure that all .mar files required for generating incremental ones on OS X contain code-signed bits
| Reported by: | gk | Owned by: | tbb-team |
|---|---|---|---|
| Priority: | Medium | Milestone: | |
| Component: | Applications/Tor Browser | Version: | |
| Severity: | Normal | Keywords: | tbb-gitian, TorBrowserTeam201610R |
| Cc: | boklm, mcs, brade | Actual Points: | |
| Parent ID: | Points: | ||
| Reviewer: | Sponsor: |
Description
While doing the 6.5a3 release it occurred to me we need to make sure every time we create the incrementals for OS X all involved full .mar files contain the code-signed bits. Otherwise the incremental files will fail.
We should have a check for this as this is easily forgotten, especially if different people are creating the .incremental mar files.
Child Tickets
Change History (3)
comment:1 Changed 4 years ago by
| Keywords: | TorBrowserTeam201610 added; TorBrowserTeam201609 removed |
|---|
comment:2 Changed 4 years ago by
| Keywords: | TorBrowserTeam201610R added; TorBrowserTeam201610 removed |
|---|---|
| Status: | new → needs_revision |
The branch bug_20217 in my git repo has a patch for this:
https://gitweb.torproject.org/user/boklm/tor-browser-bundle.git/commit/?h=bug_20217
When generating the OSX incremental MARs from make dmg2mars or make dmg2mars-alpha, we are now checking that both the new and the old MAR files contain a file in TorBrowser.app/Contents/_CodeSignature/CodeResources.
I checked that it fails with an error when the mar file from the old version is not code signed.
comment:3 Changed 4 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | needs_revision → closed |
Looks good, thanks. Merged to master (commit 9836227e4ae27123a3eb27167dc6dca13b5d1027).
Moving tickets to October.