Opened 3 years ago

Closed 2 years ago

#20221 closed defect (wontfix)

Hardened Tor Browser does not produce stack traces.

Reported by: mikeperry Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: tbb-hardened, TorBrowserTeam201702, GeorgKoppen201702
Cc: boklm, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #19515 and other bugs, we seem not to be getting full stack traces for issues.

It is common just to get: "==537696==AddressSanitizer: while reporting a bug found another one. Ignoring." or similar, rather than something that could be converted with the symbolizer as per https://trac.torproject.org/projects/tor/wiki/doc/TorBrowser/Hacking#ConvertASansstacktracemessage.

As per https://github.com/google/sanitizers/issues/391, it sounds like we may just need to add fast_unwind_on_fatal=1 to our ASAN_OPTIONS? Or maybe we need to update/switch to the latest stack unwinder: https://code.google.com/p/chromium/issues/detail?id=490275

I think it is pretty important to get this working, as I've experienced a couple crashes I couldn't do anything about. The ability to get valid crash report data from the wild from our hardened builds is extremely valuable.

Child Tickets

Change History (14)

comment:1 Changed 3 years ago by mikeperry

GeKo reports that the ASAN_OPTIONS line did not fix the problem for him in 6.0a5, which was before selfrando.

I will ping the self-rando people to see what they did differently to allow the text in that wiki entry to work.

comment:2 Changed 3 years ago by gk

Some notes before I forget them:

1) This is not selfrando related but happens with a normal ASan build done in our Gitian environment as well
2) Not stripping the binaries solves the problem
3) Building the code locally and stripping it works fine
4) Stripping the Gitian build results locally breaks, too

comment:3 Changed 3 years ago by gk

Keywords: GeorgKoppen201612 TorBrowserTeam201612 added

comment:4 Changed 3 years ago by arthuredelstein

Parent ID: #20955

comment:5 Changed 3 years ago by gk

Keywords: tbb-hardened added

comment:6 Changed 3 years ago by arthuredelstein

Parent ID: #20955

comment:7 Changed 3 years ago by gk

Bumping binutils to 2.27 does not help either.

comment:8 Changed 3 years ago by gk

Keywords: TorBrowserTeam201701 added; TorBrowserTeam201612 removed

Moving our tickets to January 2017

comment:9 Changed 3 years ago by gk

Keywords: GeorgKoppen201701 added; GeorgKoppen201612 removed

comment:10 Changed 3 years ago by gk

Keywords: TorBrowserTeam201702 added; TorBrowserTeam201701 removed

Moving our tickets to Feb 2017.

comment:11 Changed 3 years ago by gk

Keywords: GeorgKoppen201702 added; GeorgKoppen201701 removed

Moving my tickets as well

comment:12 Changed 2 years ago by arma

Close because there is no more hardened browser? Or keep open and move to be about one of the other tor browser builds?

comment:13 Changed 2 years ago by gk

We plan to have debug builds with ASan soon again, so I am inclined to leave that open for now to remind us of the issue.

comment:14 Changed 2 years ago by gk

Resolution: wontfix
Status: newclosed

Nothing to fix here anymore.

Note: See TracTickets for help on using tickets.