Opened 3 years ago

Closed 3 years ago

#20242 closed defect (fixed)

update changelog to say how many fallbacks we removed and how many remain

Reported by: arma Owned by: teor
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor: 0.2.9.3-alpha
Severity: Normal Keywords: 029-backport, 028-backport, TorCoreTeam201612
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

I just talked to teor about an idea where, when we say things like

    - Remove broken entries from the hard-coded fallback directory list.
      Closes ticket 20190; patch by teor.

we should say how many we removed and how many remain.

This will be useful in the short term for reassuring ourselves that enough remain, and in the longer term for analyzing patterns in how our working fallback sets decay.

Child Tickets

Change History (15)

comment:1 Changed 3 years ago by arma

Owner: set to teor
Status: newassigned

comment:2 Changed 3 years ago by teor

Actual Points: 0.1
Keywords: 029-proposed added
Milestone: Tor: 0.2.???
Points: 0.1
Status: assignedneeds_review
Version: Tor: 0.2.9.3-alpha

Please see the branch rewrite-fallback-changelog on my github.
I don't know how to reflow changelog entries, hopefully the spacing isn't too far off.

comment:3 Changed 3 years ago by teor

I also added example changelog entries to the fallback update instructions, so we should write better messages in future:

https://trac.torproject.org/projects/tor/wiki/doc/UpdatingFallbackDirectoryMirrors#FormattingChangesFiles

comment:4 Changed 3 years ago by teor

Keywords: TorCoreTeam201609 added

comment:5 Changed 3 years ago by arma

Looks good to me! I think merging (or cherry-picking, or whatever is best) just to master is a fine plan.

Also, a separate changes stanza for this update is probably not so useful -- it's not like this change went into a particular version of Tor.

comment:6 Changed 3 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.3.0.x-final

comment:7 Changed 3 years ago by teor

Keywords: TorCoreTeam201611 added; 029-proposed TorCoreTeam201609 removed

comment:8 Changed 3 years ago by arma

Resolution: implemented
Status: needs_reviewclosed

I stripped off the changes file and merged it to master. Woo!

comment:9 Changed 3 years ago by nickm

Resolution: implemented
Status: closedreopened

Sure you don't want to backport it to 0.2.9 ? Otherwise it won't appear in changelogs that come out for future 0.2.9 versions?

comment:10 in reply to:  9 Changed 3 years ago by teor

Replying to nickm:

Sure you don't want to backport it to 0.2.9 ? Otherwise it won't appear in changelogs that come out for future 0.2.9 versions?

I'd be happy for an 0.2.9 backport (the fallback feature itself was introduced in 0.2.8, not sure if we want to backport the relevant parts of the changelog that far back).

comment:11 in reply to:  9 Changed 3 years ago by arma

Replying to nickm:

Sure you don't want to backport it to 0.2.9 ? Otherwise it won't appear in changelogs that come out for future 0.2.9 versions?

The change really was simply a change to old stanzas in the changelog. So future 0.2.9 versions can have better changelog entries because teor's improved scripts (not included in this merge) will produce better ones.

So I think it's fine as-is. But if somebody wants to merge the changes into maint-0.2.9 too, it is fine with me!

comment:12 Changed 3 years ago by teor

Keywords: 029-backport 028-backport added
Milestone: Tor: 0.3.0.x-finalTor: 0.2.9.x-final
Status: reopenedmerge_ready

It would be nice to get this backported to 0.2.9 and 0.2.8, otherwise the backported fallback list in #20170 won't make as much sense.

The patch should easily port to 0.2.9 and 0.2.8, because we've only changed the fallbacks in 0.2.8, and not in 0.2.9 (yet).

comment:13 Changed 3 years ago by dgoulet

Keywords: TorCoreTeam201612 added; TorCoreTeam201611 removed

Going to December!

comment:14 Changed 3 years ago by nickm

Hm. I'm actually thinking that the backport isn't so likely now, given that 029 is stable. All other things being equal, I prefer not to change old changelogs.

comment:15 Changed 3 years ago by teor

Resolution: fixed
Status: merge_readyclosed

Ok, let's kill this task then: it's been merged to master.

Note: See TracTickets for help on using tickets.