update changelog to say how many fallbacks we removed and how many remain

I just talked to teor about an idea where, when we say things like

    - Remove broken entries from the hard-coded fallback directory list.
      Closes ticket 20190; patch by teor.

we should say how many we removed and how many remain.

This will be useful in the short term for reassuring ourselves that enough remain, and in the longer term for analyzing patterns in how our working fallback sets decay.

changed milestone to %Tor: 0.2.9.x-final

added 028-backport 029-backport TorCoreTeam201612 actualpoints::0.1 component::core tor/tor milestone::Tor: 0.2.9.x-final owner::teor points::0.1 priority::medium resolution::fixed severity::normal status::closed type::defect version::tor 0.2.9.3-alpha labels

Trac:
Status: new to assigned
Owner: N/A to teor

Please see the branch rewrite-fallback-changelog on my github. I don't know how to reflow changelog entries, hopefully the spacing isn't too far off.

Trac:
Milestone: N/A to Tor: 0.2.???
Keywords: N/A deleted, 029-proposed added
Actualpoints: N/A to 0.1
Status: assigned to needs_review
Points: N/A to 0.1
Version: N/A to Tor: 0.2.9.3-alpha

I also added example changelog entries to the fallback update instructions, so we should write better messages in future:

https://trac.torproject.org/projects/tor/wiki/doc/UpdatingFallbackDirectoryMirrors#FormattingChangesFiles

Trac:
Keywords: N/A deleted, TorCoreTeam201609 added

Looks good to me! I think merging (or cherry-picking, or whatever is best) just to master is a fine plan.

Also, a separate changes stanza for this update is probably not so useful -- it's not like this change went into a particular version of Tor.

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.3.0.x-final

Trac:
Keywords: TorCoreTeam201609, 029-proposed deleted, TorCoreTeam201611 added

I stripped off the changes file and merged it to master. Woo!

Trac:
Resolution: N/A to implemented
Status: needs_review to closed

Sure you don't want to backport it to 0.2.9 ? Otherwise it won't appear in changelogs that come out for future 0.2.9 versions?

Trac:
Status: closed to reopened
Resolution: implemented to N/A

Replying to nickm:

Sure you don't want to backport it to 0.2.9 ? Otherwise it won't appear in changelogs that come out for future 0.2.9 versions?

I'd be happy for an 0.2.9 backport (the fallback feature itself was introduced in 0.2.8, not sure if we want to backport the relevant parts of the changelog that far back).

Replying to nickm:

Sure you don't want to backport it to 0.2.9 ? Otherwise it won't appear in changelogs that come out for future 0.2.9 versions?

The change really was simply a change to old stanzas in the changelog. So future 0.2.9 versions can have better changelog entries because teor's improved scripts (not included in this merge) will produce better ones.

So I think it's fine as-is. But if somebody wants to merge the changes into maint-0.2.9 too, it is fine with me!

It would be nice to get this backported to 0.2.9 and 0.2.8, otherwise the backported fallback list in #20170 (moved) won't make as much sense.

The patch should easily port to 0.2.9 and 0.2.8, because we've only changed the fallbacks in 0.2.8, and not in 0.2.9 (yet).

Trac:
Keywords: N/A deleted, 028-backport, 029-backport added
Milestone: Tor: 0.3.0.x-final to Tor: 0.2.9.x-final
Status: reopened to merge_ready

Going to December!

Trac:
Keywords: TorCoreTeam201611 deleted, TorCoreTeam201612 added

Hm. I'm actually thinking that the backport isn't so likely now, given that 029 is stable. All other things being equal, I prefer not to change old changelogs.

Ok, let's kill this task then: it's been merged to master.

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

changed time estimate to 48m

added 48m of time spent

moved to tpo/core/tor#20242 (closed)