Opened 3 years ago

Closed 3 years ago

#20252 closed enhancement (duplicate)

Identify changes to dir-spec.txt from proposal 264

Reported by: karsten Owned by: karsten
Priority: Medium Milestone: metrics-lib 1.6.0
Component: Metrics/Library Version:
Severity: Normal Keywords:
Cc: iwakeh, atagar Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


I learned about proposal 264 this morning by finding the following warnings in CollecTor's logs:

2016-09-26 20:09:03,174 WARN o.t.c.b.SanitizedBridgesWriter:885 Unrecognized line 'proto Cons=1-2 Desc=1-2 DirCache=1 HSDir=1 HSIntro=3 HSRend=1-2 Link=1-4 LinkAuth=1 Microdesc=1-2 Relay=1-2'. Skipping.

Tor's ChangeLog indicates that this line is related to proposal 264. Here's a bridge descriptor that contains this line:

router Unnamed 443 0 0
-----BEGIN ED25519 CERT-----
-----END ED25519 CERT-----
master-key-ed25519 [...]
platform Tor on Linux
proto Cons=1-2 Desc=1-2 DirCache=1 HSDir=1 HSIntro=3 HSRend=1-2 Link=1-4 LinkAuth=1 Microdesc=1-2 Relay=1-2
published 2016-09-27 [...]
fingerprint [...]

We should identify the exact changes made in proposal 264 and adapt CollecTor's bridgedescs module ASAP. Right now, we're skipping all bridge descriptors containing such a line, and we'll have to reprocess them once the patch is merged.

Once we did that, we should consider updating metrics-lib to handle these lines in both relay and bridge descriptors.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by karsten

Component: Metrics/CollecTorMetrics/metrics-lib
Owner: set to karsten
Priority: HighMedium

Okay, I looked at the changes and believe that it's safe to just keep these lines in sanitized bridge server descriptors. Pushed the trivial patch, will deploy it this hour.

Now we need to make plans for parsing these new lines in metrics-lib, so I'm moving this to the metrics-lib component. I'm also reducing priority to medium, because nothing's on fire while we discuss adding this feature.

comment:2 Changed 3 years ago by karsten

Milestone: metrics-lib 1.6.0

Maybe something for 1.6.0.

comment:3 Changed 3 years ago by karsten

Resolution: duplicate
Status: newclosed

I started writing a patch to support these new lines in #20765. Closing as near-duplicate.

Note: See TracTickets for help on using tickets.