Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20266 closed defect (wontfix)

Provide a shim for SSL_cipher_get_id in OpenSSL versions < 1.0.1

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: regression, openssl
Cc: Actual Points: .1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

Tor fails to compile on OpenSSL 1.0.0, because we use SSL_cipher_get_id, which was introduced in OpenSSL 1.0.1.

We can access the id member of the cipher object instead, like this:
https://github.com/SlimRoms/android_external_chromium/commit/731158395b8ae1105c69cc42dae6244385f6b4ff

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by teor

Discovered by Marsh Ray.

comment:2 Changed 3 years ago by nickm

Status: newneeds_review

Like this? (see my branch bug20266_028.) Though actually, I think we should consider this as a possible "wontfix" for these reasons:

  1. It's been like this since at least 0.2.8; maybe even since 0.2.7. This is the first time somebody complained afaik. :)
  2. OpenSSL 1.0.0 has not been supported since 31 Dec 2015, and is no longer getting security updates.

comment:3 Changed 3 years ago by nickm

Actual Points: .1

comment:4 Changed 3 years ago by nickm

Resolution: wontfix
Status: needs_reviewclosed

Closing as wontfix; opening a new ticket to drop 1.0.0 support.

comment:5 Changed 3 years ago by nickm

#20303 is the ticket about dropping openssl 1.0.0

Note: See TracTickets for help on using tickets.