Opened 12 months ago

Closed 8 weeks ago

#20270 closed defect (fixed)

"Descriptor is missing an ntor curve25519 onion key" message too noisy?

Reported by: arma Owned by: nickm
Priority: Low Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version: Tor: 0.2.9.3-alpha
Severity: Normal Keywords: easy, TorCoreTeam201705, 029-backport, 030-backport
Cc: teor Actual Points: .1
Parent ID: Points: .2
Reviewer: Sponsor:

Description

On moria1, I have a lot of these:

Oct 01 18:01:05.421 [notice] Descriptor from router $E0671CF9CB593F27CD389CD4DD819BF9448EA834~ordb1 at 37.59.47.27 is missing an ntor curve25519 onion key.
Oct 01 18:01:20.530 [notice] Descriptor from router $179B10784BF8955C73313CCB195904AE133E5F53~ordb3 at 37.59.47.27 is missing an ntor curve25519 onion key.
Oct 01 18:03:21.653 [notice] Descriptor from router $993992BBD01E36D3ECF8BA0B802C158961BB257C~orchard at 106.186.18.242 is missing an ntor curve25519 onion key.
Oct 01 18:04:00.856 [notice] Descriptor from router $496FED39C1469567B333C3A418A07D5CF62DCD23~rationalist at 87.106.249.248 is missing an ntor curve25519 onion key.
Oct 01 18:14:14.418 [notice] Descriptor from router $184A39F7F891D46592216643CD74DDE50C6DAA75~FlandersRegional at 89.106.244.21 is missing an ntor curve25519 onion key.
Oct 01 18:15:16.620 [notice] Descriptor from router $1AFA214C8AE557640BD29A0A8D674F92EB20948D~Unnamdddd at 95.78.221.81 is missing an ntor curve25519 onion key.
Oct 01 18:23:29.590 [notice] Descriptor from router $40E632BED95FC71E5B622DBB9E336D89A6D52600~younix at 85.214.63.239 is missing an ntor curve25519 onion key.

teor thinks this wasn't really meant to be a notice-level log every time an obsolete relay tries to upload to me.

That said, I think the first two of these relays (ordb1 and ordb3) are actually that alternative nodejs Tor relay implementation, right?

So I think maybe I *do* want to hear about relays that I refused due to lack of an ntor curve onion key, but only the ones that had a satisfactory version string?

Child Tickets

Change History (17)

comment:1 Changed 12 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.2.9.x-final

comment:2 Changed 12 months ago by nickm

Keywords: easy added

comment:3 Changed 12 months ago by nickm

So I think maybe I *do* want to hear about relays that I refused due to lack of an ntor curve onion key, but only the ones that had a satisfactory version string?

Sounds reasonable to me.

I'd be glad to take a patch here for 029 if somebody writes one by the 15th. Else it can wait till 030.

comment:4 Changed 11 months ago by nickm

Milestone: Tor: 0.2.9.x-finalTor: 0.3.0.x-final

comment:5 Changed 9 months ago by dgoulet

Keywords: triage-out-030-201612 added
Milestone: Tor: 0.3.0.x-finalTor: 0.3.1.x-final

Triaged out on December 2016 from 030 to 031.

comment:6 Changed 7 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:7 Changed 7 months ago by nickm

Points: .2

comment:8 Changed 7 months ago by nickm

Priority: MediumLow

Lower priority on some of my assigned tickets

comment:9 Changed 6 months ago by nickm

So, right now authdir_wants_to_reject_router is deciding on what severity to use like this:

  int severity = (complain && ri->contact_info) ? LOG_NOTICE : LOG_INFO;

In theory, these are all ones that we could contact to tell them to upgrade.

Should I wontfix this, or think about other behavior improvements?

comment:10 Changed 5 months ago by nickm

Status: acceptedneeds_information

I'm happy to change the behavior here to be what the directory authority operators want... but I do need to know what that is. :)

comment:11 Changed 5 months ago by arma

Behavior I think I want: if the relay's version is obsolete, don't complain about the ntor key -- do whatever logs I would do for an obsolete relay. If the relay's version is not obsolete, *and* it's missing an ntor key, then tell me.

comment:12 Changed 5 months ago by nickm

Status: needs_informationaccepted

comment:13 Changed 5 months ago by nickm

Actual Points: .1
Keywords: TorCoreTeam201705 029-backport 030-backport added
Status: acceptedneeds_review

Okay. My branch bug20270_029 does that.

I suggest that we don't backport it any farther than 0.3.0, since authorities usually stay up-to-date with the latest stable, if not even more up-to-date.

comment:14 Changed 4 months ago by nickm

Milestone: Tor: 0.3.1.x-finalTor: 0.3.0.x-final

Trying this in 0.3.1, after review from ln5. If nothing breaks, let's backport.

comment:15 Changed 4 months ago by nickm

Status: needs_reviewmerge_ready

comment:16 Changed 4 months ago by nickm

Keywords: triage-out-030-201612 removed

comment:17 Changed 8 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed

Backported to 0.3.0 and closing.

Note: See TracTickets for help on using tickets.