Opened 8 months ago

Closed 7 months ago

#20273 closed defect (fixed)

consensus weight inaccuracies: 1 --> weight_scale

Reported by: pastly Owned by:
Priority: Low Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: review-group-10
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Comment states that Wmm=1, but code does Wmm=weight_scale. Update comment to reflect code's behavior because I'm betting the code is correct.

See patch that I'll upload once I get a ticket number.

Child Tickets

Attachments (3)

comment.change.20273.patch (609 bytes) - added by pastly 8 months ago.
comment.change.20273.1.patch (947 bytes) - added by pastly 8 months ago.
dir-spec.change.20273.patch (1.2 KB) - added by pastly 8 months ago.

Download all attachments as: .zip

Change History (10)

Changed 8 months ago by pastly

comment:1 Changed 8 months ago by pastly

  • Summary changed from consensus weight Wmm comment inaccuracy to consensus weight inaccuracies: 1 --> weight_scale

Adding two more patches for inaccurate documentation/comments and generalizing this ticket.

comment.change.20273*.patch should be applied to Tor. dir-spec.change.20273*.patch should be applied to torspec.

Changed 8 months ago by pastly

Changed 8 months ago by pastly

comment:2 Changed 8 months ago by pastly

Not ready to merge. There are more places where Wxx=1 exists in comments and dir-spec

comment:3 Changed 8 months ago by nickm

  • Milestone set to Tor: 0.3.0.x-final

comment:4 Changed 8 months ago by pastly

  • Status changed from new to needs_review

Okay ignore the patches. I've pushed a branch for tor and a branch for torspec. They should incorporate the patches and more.

https://github.com/pastly/public-tor/tree/ticket20273
https://github.com/pastly/torspec/tree/ticket20273

comment:5 Changed 8 months ago by nickm

  • Keywords review-group-10 added

Add 0.3.0 needs_review items (and ones that haven't been in needs_revision for very long) to review-group-10.

comment:6 Changed 7 months ago by asn

  • Status changed from needs_review to merge_ready

The documentation fixes here look good to me and make the code and spec more accurate.

comment:7 Changed 7 months ago by nickm

  • Resolution set to fixed
  • Status changed from merge_ready to closed

Thanks; merged!

Note: See TracTickets for help on using tickets.