Opened 3 years ago

Closed 3 years ago

#20277 closed defect (fixed)

Confusing "Not all bridges handle conditional consensus downloading" comment

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

There's this comment in directory.c:

      /* XXX+++++ Not all bridges handle conditional consensus downloading,
       * so, for now, never assume the server supports that. -PP
       * Is that assumption still so in 2016? -NM */

And you're right, the conditional consensus stuff has been in since Tor 0.2.1.x.

So I went to go rip out the special-casing code, but it already got ripped out in git commit 7988596f (which went into Tor 0.2.4.2-alpha).

And then, inexplicably, I seem to have added the stanza back in during git commit a8297cdbd3 (which went into Tor 0.2.4.11-alpha).

I just looked around at the code some more and I'm now convinced that indeed that code is gone. We should fix the comments.

Child Tickets

Change History (2)

comment:1 Changed 3 years ago by arma

Status: newneeds_review

My bug20277 branch resolves this ticket.

(I didn't add a changes/ file since this is just internal code cleanup. Maybe your instincts suggest otherwise?)

comment:2 Changed 3 years ago by nickm

Resolution: fixed
Reviewer: nickm
Status: needs_reviewclosed

Merged to master as trivially correct.

Note: See TracTickets for help on using tickets.